diff options
| author | Andrea Arcangeli <aarcange@redhat.com> | 2010-09-22 13:05:12 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-09-26 17:18:25 -0700 |
| commit | e675865c92e66331dba733c544eb53b3d6c45eaa (patch) | |
| tree | 9bf1a89b216395aa46617b87183277ff9a63e2d1 /mm | |
| parent | b932db652630421d4a75e3b661995962a856bf64 (diff) | |
mmap: call unlink_anon_vmas() in __split_vma() in case of error
commit 2aeadc30de45a72648f271603203ab392b80f607 upstream.
If __split_vma fails because of an out of memory condition the
anon_vma_chain isn't teardown and freed potentially leading to rmap walks
accessing freed vma information plus there's a memleak.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Johannes Weiner <jweiner@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/mmap.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/mm/mmap.c b/mm/mmap.c index 3867cfc21cc..12d38bf4f5b 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1997,6 +1997,7 @@ static int __split_vma(struct mm_struct * mm, struct vm_area_struct * vma, removed_exe_file_vma(mm); fput(new->vm_file); } + unlink_anon_vmas(new); out_free_mpol: mpol_put(pol); out_free_vma: |