diff options
| author | Dean Nelson <dnelson@redhat.com> | 2010-12-02 14:31:12 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:33:15 -0800 |
| commit | befb3a2d6721ecdc380d2047cffe24419c11fa24 (patch) | |
| tree | df4572e54b087991a047d665953aa1cb322b5b2e /mm | |
| parent | 9b504ae860868e8d0c8376b14235ebdfbfaf7fb5 (diff) | |
mm/hugetlb.c: avoid double unlock_page() in hugetlb_fault()
commit 1f64d69c7ad2e48e697493e45590679f7a69b7b2 upstream.
Have hugetlb_fault() call unlock_page(page) only if it had previously
called lock_page(page).
Setting CONFIG_DEBUG_VM=y and then running the libhugetlbfs test suite,
resulted in the tripping of VM_BUG_ON(!PageLocked(page)) in
unlock_page() having been called by hugetlb_fault() when page ==
pagecache_page. This patch remedied the problem.
Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/hugetlb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 8ee804bdbba..2697806746d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2668,7 +2668,8 @@ out_page_table_lock: unlock_page(pagecache_page); put_page(pagecache_page); } - unlock_page(page); + if (page != pagecache_page) + unlock_page(page); out_mutex: mutex_unlock(&hugetlb_instantiation_mutex); |