diff options
author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2009-02-02 18:33:49 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-02-17 09:46:17 -0800 |
commit | 7d120e20744a6a8d9dc3a3342bf9c385c44a3aaf (patch) | |
tree | 53b3acb00b9f5611dfbab28efff5455698754571 /mm/migrate.c | |
parent | c7e66cfbd26497e27a33a54d93d116095fc25512 (diff) |
write-back: fix nr_to_write counter
commit dcf6a79dda5cc2a2bec183e50d829030c0972aaa upstream.
Commit 05fe478dd04e02fa230c305ab9b5616669821dd3 introduced some
@wbc->nr_to_write breakage.
It made the following changes:
1. Decrement wbc->nr_to_write instead of nr_to_write
2. Decrement wbc->nr_to_write _only_ if wbc->sync_mode == WB_SYNC_NONE
3. If synced nr_to_write pages, stop only if if wbc->sync_mode ==
WB_SYNC_NONE, otherwise keep going.
However, according to the commit message, the intention was to only make
change 3. Change 1 is a bug. Change 2 does not seem to be necessary,
and it breaks UBIFS expectations, so if needed, it should be done
separately later. And change 2 does not seem to be documented in the
commit message.
This patch does the following:
1. Undo changes 1 and 2
2. Add a comment explaining change 3 (it very useful to have comments
in _code_, not only in the commit).
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Acked-by: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm/migrate.c')
0 files changed, 0 insertions, 0 deletions