diff options
author | Satyam Sharma <ssatyam@cse.iitk.ac.in> | 2007-06-06 23:02:16 -0700 |
---|---|---|
committer | Chris Wright <chrisw@sous-sol.org> | 2007-06-11 11:36:54 -0700 |
commit | d951c856912acfbb85eb33f59230c3019ef5dd55 (patch) | |
tree | 504bca3dfe564fd37ab772dfc52e0d675bef2e5a /lib/sha1.c | |
parent | 02a074766a0a8d1afd26f476b73422c08e34cbc8 (diff) |
[PATCH] BLUETOOTH: Fix locking in hci_sock_dev_event().
We presently use lock_sock() to acquire a lock on a socket in
hci_sock_dev_event(), but this goes BUG because lock_sock()
can sleep and we're already holding a read-write spinlock at
that point. So, we must use the non-sleeping BH version,
bh_lock_sock().
However, hci_sock_dev_event() is called from user context and
hence using simply bh_lock_sock() will deadlock against a
concurrent softirq that tries to acquire a lock on the same
socket. Hence, disabling BH's before acquiring the socket lock
and enable them afterwards, is the proper solution to fix
socket locking in hci_sock_dev_event().
Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'lib/sha1.c')
0 files changed, 0 insertions, 0 deletions