diff options
| author | Jeff Layton <jlayton@redhat.com> | 2009-11-06 14:18:49 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-12-08 10:20:51 -0800 |
| commit | 6804b96f48a32bca16fee60212ad8e4b201bb99f (patch) | |
| tree | 77a8927491e97a0b65dd94860446eec34143f6f4 /fs | |
| parent | b88b724607b4e9472398c7b3ebc5f8cb3f1d98d6 (diff) | |
cifs: don't use CIFSGetSrvInodeNumber in is_path_accessible
commit f475f6775465283494346663f201ad04810d2e8a upstream.
Because it's lighter weight, CIFS tries to use CIFSGetSrvInodeNumber to
verify the accessibility of the root inode and then falls back to doing a
full QPathInfo if that fails with -EOPNOTSUPP. I have at least a report
of a server that returns NT_STATUS_INTERNAL_ERROR rather than something
that translates to EOPNOTSUPP.
Rather than trying to be clever with that call, just have
is_path_accessible do a normal QPathInfo. That call is widely
supported and it shouldn't increase the overhead significantly.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/connect.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 1b056d49faf..5c084e517d6 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2200,16 +2200,8 @@ is_path_accessible(int xid, struct cifsTconInfo *tcon, struct cifs_sb_info *cifs_sb, const char *full_path) { int rc; - __u64 inode_num; FILE_ALL_INFO *pfile_info; - rc = CIFSGetSrvInodeNumber(xid, tcon, full_path, &inode_num, - cifs_sb->local_nls, - cifs_sb->mnt_cifs_flags & - CIFS_MOUNT_MAP_SPECIAL_CHR); - if (rc != -EOPNOTSUPP) - return rc; - pfile_info = kmalloc(sizeof(FILE_ALL_INFO), GFP_KERNEL); if (pfile_info == NULL) return -ENOMEM; |