diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2012-02-12 21:15:58 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-03-20 21:29:34 -0400 |
| commit | f56b0fbc6477e50303a503ee1453ed94e20f154a (patch) | |
| tree | 633b2f01e678cf519012377492b28b96e5273da1 /fs/coda | |
| parent | 064326c0773af8a0e8bb82d895cceaedc8a51b9e (diff) | |
coda: clean failure exits in coda_fill_super()
same as for cifs, move iput() to the right place, make it unconditional
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/coda')
| -rw-r--r-- | fs/coda/inode.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/coda/inode.c b/fs/coda/inode.c index 5e2e1b3f068..32dafc875c1 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -208,7 +208,6 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent) if (IS_ERR(root)) { error = PTR_ERR(root); printk("Failure of coda_cnode_make for root: error %d\n", error); - root = NULL; goto error; } @@ -216,15 +215,13 @@ static int coda_fill_super(struct super_block *sb, void *data, int silent) root->i_ino, root->i_sb->s_id); sb->s_root = d_alloc_root(root); if (!sb->s_root) { + iput(root); error = -EINVAL; goto error; } return 0; error: - if (root) - iput(root); - mutex_lock(&vc->vc_mutex); bdi_destroy(&vc->bdi); vc->vc_sb = NULL; |