diff options
author | Julia Lawall <julia@diku.dk> | 2011-01-28 15:17:11 +0100 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-01-28 15:46:23 -0500 |
commit | efe1cf0c5743caf4daccb57b399ef63edad41c9d (patch) | |
tree | d482979aa5a16a49d8095dcf00b6023c9051b86f /drivers | |
parent | 76a9f6fd9adc5ce62b4ea36a099bb1458d4cb7a6 (diff) |
net/wireless/nl80211.c: Avoid call to genlmsg_cancel
genlmsg_cancel subtracts some constants from its second argument before
calling nlmsg_cancel. nlmsg_cancel then calls nlmsg_trim on the same
arguments. nlmsg_trim tests for NULL before doing any computation, but a
NULL second argument to genlmsg_cancel is no longer NULL due to the initial
subtraction. Nothing else happens in this execution, so the call to
genlmsg_cancel is simply unnecessary in this case.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression data;
@@
if (data == NULL) { ...
* genlmsg_cancel(..., data);
...
return ...;
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions