diff options
| author | Florian Fainelli <florian@openwrt.org> | 2010-06-20 22:07:48 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-02 10:29:26 -0700 |
| commit | ba7afdd80a6a91fd7fac2aa17cadb75d4b427c13 (patch) | |
| tree | b168faf0506c6b5d9d08fc0c29940bbc04ec22e6 /drivers | |
| parent | c6351bcaa687686e784b85d92e544e4c0176ef09 (diff) | |
cpmac: do not leak struct net_device on phy_connect errors
commit ed770f01360b392564650bf1553ce723fa46afec upstream.
If the call to phy_connect fails, we will return directly instead of freeing
the previously allocated struct net_device.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/cpmac.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c index 60777fd90b3..e456886946c 100644 --- a/drivers/net/cpmac.c +++ b/drivers/net/cpmac.c @@ -1182,7 +1182,8 @@ static int __devinit cpmac_probe(struct platform_device *pdev) if (netif_msg_drv(priv)) printk(KERN_ERR "%s: Could not attach to PHY\n", dev->name); - return PTR_ERR(priv->phy); + rc = PTR_ERR(priv->phy); + goto fail; } if ((rc = register_netdev(dev))) { |