aboutsummaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2008-10-10 17:28:29 +1100
committerGreg Kroah-Hartman <gregkh@suse.de>2008-10-18 10:49:11 -0700
commit769b0455c1ec257b9e5067129accab1a6052de4c (patch)
tree8c40898d7c1fb20e525894f1561239670ba77bee /drivers
parent60b216fffd66fc2ad2824a05d6838aff6b59d827 (diff)
Fix barrier fail detection in XFS
commit 73f6aa4d44ab6157badc456ddfa05b31e58de5f0 upstream. Currently we disable barriers as soon as we get a buffer in xlog_iodone that has the XBF_ORDERED flag cleared. But this can be the case not only for buffers where the barrier failed, but also the first buffer of a split log write in case of a log wraparound. Due to the disabled barriers we can easily get directory corruption on unclean shutdowns. So instead of using this check add a new buffer flag for failed barrier writes. This is a regression vs 2.6.26 caused by patch to use the right macro to check for the ORDERED flag, as we previously got true returned for every buffer. Thanks to Toei Rei for reporting the bug. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Eric Sandeen <sandeen@sandeen.net> Reviewed-by: David Chinner <david@fromorbit.com> Signed-off-by: Tim Shimmin <tes@sgi.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions