aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/dwc3
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2011-11-28 12:27:17 +0200
committerFelipe Balbi <balbi@ti.com>2011-12-21 13:24:46 +0200
commit42f8eb7a1087442e9710ce75b355c0f28aadbf96 (patch)
tree07280177242cfb046d4903709643c73b8df006e1 /drivers/usb/dwc3
parent68e823e24aea5227eaf20d6435485e733109d113 (diff)
usb: dwc3: gadget: don't force 'LST' always
the LST bit is to be set on the last of a series of consecutive TRBs. We had a workaround for a problem where data would get corrupted but that doesn't happen anymore. It's likely that it was caused by some FPGA instability during development phase. Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc3')
-rw-r--r--drivers/usb/dwc3/gadget.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 984580a18a3..0292b0617d7 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -672,16 +672,10 @@ static void dwc3_prepare_trbs(struct dwc3_ep *dep, bool starting)
if (list_empty(&dep->request_list))
last_one = 1;
- /*
- * FIXME we shouldn't need to set LST bit always but we are
- * facing some weird problem with the Hardware where it doesn't
- * complete even though it has been previously started.
- *
- * While we're debugging the problem, as a workaround to
- * multiple TRBs handling, use only one TRB at a time.
- */
- dwc3_prepare_one_trb(dep, req, true);
- break;
+ dwc3_prepare_one_trb(dep, req, last_one);
+
+ if (last_one)
+ break;
}
}