aboutsummaryrefslogtreecommitdiff
path: root/drivers/oprofile/buffer_sync.h
diff options
context:
space:
mode:
authorHelge Deller <deller@gmx.de>2008-11-26 12:46:22 -0800
committerGreg Kroah-Hartman <gregkh@suse.de>2008-12-05 10:55:11 -0800
commit16a476e1419249a1c0733fdb683f29c9bde6f941 (patch)
tree63856d13352e579fbd74df671067ecae7dd8b773 /drivers/oprofile/buffer_sync.h
parentcbb502daa826e51ecdc50e7458aaf6216bc87cce (diff)
parisc: fix kernel crash when unwinding a userspace process
commit 7a3f5134a8f5bd7fa38b5645eef05e8a4eb62951 upstream. Any user on existing parisc 32- and 64bit-kernels can easily crash the kernel and as such enforce a DSO. A simple testcase is available here: http://gsyprf10.external.hp.com/~deller/crash.tgz The problem is introduced by the fact, that the handle_interruption() crash handler calls the show_regs() function, which in turn tries to unwind the stack by calling parisc_show_stack(). Since the stack contains userspace addresses, a try to unwind the stack is dangerous and useless and leads to the crash. The fix is trivial: For userspace processes a) avoid to unwind the stack, and b) avoid to resolve userspace addresses to kernel symbol names. While touching this code, I converted print_symbol() to %pS printk formats and made parisc_show_stack() static. An initial patch for this was written by Kyle McMartin back in August: http://marc.info/?l=linux-parisc&m=121805168830283&w=2 Compile and run-tested with a 64bit parisc kernel. Signed-off-by: Helge Deller <deller@gmx.de> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: Matthew Wilcox <matthew@wil.cx> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Kyle McMartin <kyle@mcmartin.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/oprofile/buffer_sync.h')
0 files changed, 0 insertions, 0 deletions