diff options
author | David Vrabel <david.vrabel@citrix.com> | 2012-04-26 19:44:06 +0100 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2012-05-11 13:14:32 +0100 |
commit | 585bfaac76e8392e83e82b7457de2f326f29fded (patch) | |
tree | 2ed69a9cfb54b029f2075ab7776ae2f0b592b507 /drivers/of/gpio.c | |
parent | 72f1409d18618284d29f22823270ad8c370911a0 (diff) |
xen: correctly check for pending events when restoring irq flags
commit 7eb7ce4d2e8991aff4ecb71a81949a907ca755ac upstream.
In xen_restore_fl_direct(), xen_force_evtchn_callback() was being
called even if no events were pending. This resulted in (depending on
workload) about a 100 times as many xen_version hypercalls as
necessary.
Fix this by correcting the sense of the conditional jump.
This seems to give a significant performance benefit for some
workloads.
There is some subtle tricksy "..since the check here is trying to
check both pending and masked in a single cmpw, but I think this is
correct. It will call check_events now only when the combined
mask+pending word is 0x0001 (aka unmasked, pending)." (Ian)
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/of/gpio.c')
0 files changed, 0 insertions, 0 deletions