diff options
| author | Ingo Molnar <mingo@elte.hu> | 2009-05-11 14:44:27 +0200 | 
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-05-11 14:44:31 +0200 | 
| commit | 41fb454ebe6024f5c1e3b3cbc0abc0da762e7b51 (patch) | |
| tree | 51c50bcb67a5039448ddfa1869d7948cab1217e9 /drivers/net/virtio_net.c | |
| parent | 19c1a6f5764d787113fa323ffb18be7991208f82 (diff) | |
| parent | 091bf7624d1c90cec9e578a18529f615213ff847 (diff) | |
Merge commit 'v2.6.30-rc5' into core/iommu
Merge reason: core/iommu was on an .30-rc1 base,
              update it to .30-rc5 to refresh.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/net/virtio_net.c')
| -rw-r--r-- | drivers/net/virtio_net.c | 24 | 
1 files changed, 14 insertions, 10 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9c82a39497e..4d1d47953fc 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -616,10 +616,11 @@ static int virtnet_open(struct net_device *dev)  static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,  				 struct scatterlist *data, int out, int in)  { -	struct scatterlist sg[VIRTNET_SEND_COMMAND_SG_MAX + 2]; +	struct scatterlist *s, sg[VIRTNET_SEND_COMMAND_SG_MAX + 2];  	struct virtio_net_ctrl_hdr ctrl;  	virtio_net_ctrl_ack status = ~0;  	unsigned int tmp; +	int i;  	if (!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) {  		BUG();  /* Caller should know better */ @@ -637,7 +638,8 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,  	sg_init_table(sg, out + in);  	sg_set_buf(&sg[0], &ctrl, sizeof(ctrl)); -	memcpy(&sg[1], data, sizeof(struct scatterlist) * (out + in - 2)); +	for_each_sg(data, s, out + in - 2, i) +		sg_set_buf(&sg[i + 1], sg_virt(s), s->length);  	sg_set_buf(&sg[out + in - 1], &status, sizeof(status));  	if (vi->cvq->vq_ops->add_buf(vi->cvq, sg, out, in, vi) != 0) @@ -692,7 +694,7 @@ static void virtnet_set_rx_mode(struct net_device *dev)  	promisc = ((dev->flags & IFF_PROMISC) != 0);  	allmulti = ((dev->flags & IFF_ALLMULTI) != 0); -	sg_set_buf(sg, &promisc, sizeof(promisc)); +	sg_init_one(sg, &promisc, sizeof(promisc));  	if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_RX,  				  VIRTIO_NET_CTRL_RX_PROMISC, @@ -700,7 +702,7 @@ static void virtnet_set_rx_mode(struct net_device *dev)  		dev_warn(&dev->dev, "Failed to %sable promisc mode.\n",  			 promisc ? "en" : "dis"); -	sg_set_buf(sg, &allmulti, sizeof(allmulti)); +	sg_init_one(sg, &allmulti, sizeof(allmulti));  	if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_RX,  				  VIRTIO_NET_CTRL_RX_ALLMULTI, @@ -716,6 +718,8 @@ static void virtnet_set_rx_mode(struct net_device *dev)  		return;  	} +	sg_init_table(sg, 2); +  	/* Store the unicast list and count in the front of the buffer */  	mac_data->entries = dev->uc_count;  	addr = dev->uc_list; @@ -744,24 +748,24 @@ static void virtnet_set_rx_mode(struct net_device *dev)  	kfree(buf);  } -static void virnet_vlan_rx_add_vid(struct net_device *dev, u16 vid) +static void virtnet_vlan_rx_add_vid(struct net_device *dev, u16 vid)  {  	struct virtnet_info *vi = netdev_priv(dev);  	struct scatterlist sg; -	sg_set_buf(&sg, &vid, sizeof(vid)); +	sg_init_one(&sg, &vid, sizeof(vid));  	if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_VLAN,  				  VIRTIO_NET_CTRL_VLAN_ADD, &sg, 1, 0))  		dev_warn(&dev->dev, "Failed to add VLAN ID %d.\n", vid);  } -static void virnet_vlan_rx_kill_vid(struct net_device *dev, u16 vid) +static void virtnet_vlan_rx_kill_vid(struct net_device *dev, u16 vid)  {  	struct virtnet_info *vi = netdev_priv(dev);  	struct scatterlist sg; -	sg_set_buf(&sg, &vid, sizeof(vid)); +	sg_init_one(&sg, &vid, sizeof(vid));  	if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_VLAN,  				  VIRTIO_NET_CTRL_VLAN_DEL, &sg, 1, 0)) @@ -794,8 +798,8 @@ static const struct net_device_ops virtnet_netdev = {  	.ndo_set_mac_address = virtnet_set_mac_address,  	.ndo_set_rx_mode     = virtnet_set_rx_mode,  	.ndo_change_mtu	     = virtnet_change_mtu, -	.ndo_vlan_rx_add_vid = virnet_vlan_rx_add_vid, -	.ndo_vlan_rx_kill_vid = virnet_vlan_rx_kill_vid, +	.ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, +	.ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid,  #ifdef CONFIG_NET_POLL_CONTROLLER  	.ndo_poll_controller = virtnet_netpoll,  #endif  | 
