diff options
author | Mikulas Patocka <mpatocka@redhat.com> | 2014-01-06 23:01:22 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-13 13:50:17 -0800 |
commit | 7cc8d93049998a20834b50fd4a7bd0f14feb59b3 (patch) | |
tree | 3f0322b9925517ea2753e898c13e041e5373909b /drivers/md/persistent-data/dm-space-map-metadata.h | |
parent | 465c661f3e4957f1014cbc3e3dcdfd542a7b3c7a (diff) |
dm: wait until embedded kobject is released before destroying a device
commit be35f486108227e10fe5d96fd42fb2b344c59983 upstream.
There may be other parts of the kernel holding a reference on the dm
kobject. We must wait until all references are dropped before
deallocating the mapped_device structure.
The dm_kobject_release method signals that all references are dropped
via completion. But dm_kobject_release doesn't free the kobject (which
is embedded in the mapped_device structure).
This is the sequence of operations:
* when destroying a DM device, call kobject_put from dm_sysfs_exit
* wait until all users stop using the kobject, when it happens the
release method is called
* the release method signals the completion and should return without
delay
* the dm device removal code that waits on the completion continues
* the dm device removal code drops the dm_mod reference the device had
* the dm device removal code frees the mapped_device structure that
contains the kobject
Using kobject this way should avoid the module unload race that was
mentioned at the beginning of this thread:
https://lkml.org/lkml/2014/1/4/83
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/md/persistent-data/dm-space-map-metadata.h')
0 files changed, 0 insertions, 0 deletions