diff options
author | David Herrmann <dh.herrmann@gmail.com> | 2013-12-19 12:09:32 +0100 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2014-02-17 21:17:55 +0100 |
commit | a4b1b5877b514b276f0f31efe02388a9c2836728 (patch) | |
tree | a09dd741c0a2b98db2ab8f71b45c5dc92efcc02c /drivers/hid | |
parent | 218eb9ed840c6279686ed6b0c3e31a083e241ff9 (diff) |
HID: Bluetooth: hidp: make sure input buffers are big enough
HID core expects the input buffers to be at least of size 4096
(HID_MAX_BUFFER_SIZE). Other sizes will result in buffer-overflows if an
input-report is smaller than advertised. We could, like i2c, compute the
biggest report-size instead of using HID_MAX_BUFFER_SIZE, but this will
blow up if report-descriptors are changed after ->start() has been called.
So lets be safe and just use the biggest buffer we have.
Note that this adds an additional copy to the HIDP input path. If there is
a way to make sure the skb-buf is big enough, we should use that instead.
The best way would be to make hid-core honor the @size argument, though,
that sounds easier than it is. So lets just fix the buffer-overflows for
now and afterwards look for a faster way for all transport drivers.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
0 files changed, 0 insertions, 0 deletions