diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2009-02-03 17:55:19 +0100 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2009-03-24 20:56:48 +0100 |
commit | e1eff7a393d4a4e3ad1cf65fcba899146840bfd2 (patch) | |
tree | 88a040babea1853f40072ed199a78b60f4dcb387 /drivers/firewire/fw-iso.c | |
parent | d01b01787680a1156ff6a554e40baa460bb88efb (diff) |
firewire: normalize a variable name
Standardize on if (err)
handle_error;
and if (ret < 0)
handle_error;
Don't call a variable err if we store values in it which mean success.
Also, offset some return statements by a blank line since this how we do
it in drivers/firewire.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-iso.c')
-rw-r--r-- | drivers/firewire/fw-iso.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/firewire/fw-iso.c b/drivers/firewire/fw-iso.c index f511d16efae..2baf1007253 100644 --- a/drivers/firewire/fw-iso.c +++ b/drivers/firewire/fw-iso.c @@ -75,19 +75,21 @@ int fw_iso_buffer_init(struct fw_iso_buffer *buffer, struct fw_card *card, kfree(buffer->pages); out: buffer->pages = NULL; + return -ENOMEM; } int fw_iso_buffer_map(struct fw_iso_buffer *buffer, struct vm_area_struct *vma) { unsigned long uaddr; - int i, ret; + int i, err; uaddr = vma->vm_start; for (i = 0; i < buffer->page_count; i++) { - ret = vm_insert_page(vma, uaddr, buffer->pages[i]); - if (ret) - return ret; + err = vm_insert_page(vma, uaddr, buffer->pages[i]); + if (err) + return err; + uaddr += PAGE_SIZE; } |