diff options
| author | Catalin Marinas <catalin.marinas@arm.com> | 2010-02-04 01:04:50 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-02-23 07:37:55 -0800 |
| commit | 2c494f553a2c3c9dc155fc5bb0eff27e3a0fbef2 (patch) | |
| tree | c4a15c4a245cf8c72a7d606386963509b62355aa /drivers/ata | |
| parent | c74c819eabc8b9ccfc91eafc8c253bce57661dae (diff) | |
Call flush_dcache_page after PIO data transfers in libata-sff.c
commit 2d68b7fe55d9e19a8a868224ed0dfd6526568521 upstream.
flush_dcache_page() must be called after (!ATA_TFLAG_WRITE) the
data copying to avoid D-cache aliasing with user space or I-D cache
coherency issues (when reading data from an ATA device using PIO,
the kernel dirties the D-cache but there is no flush_dcache_page()
required on Harvard architectures).
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-sff.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index bbbb1fab175..2ae15c3b22a 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -893,6 +893,9 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) do_write); } + if (!do_write) + flush_dcache_page(page); + qc->curbytes += qc->sect_size; qc->cursg_ofs += qc->sect_size; |