diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-01-21 20:32:05 -0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2014-01-21 20:32:05 -0800 |
| commit | 5837c80e870bc3b12ac6a98cdc9ce7a9522a8fb6 (patch) | |
| tree | 35b9a82820cf87bb133d4773e416a8d3b293b604 /block/scsi_ioctl.c | |
| parent | bca266b3886b8bc587db044750c8a00d674b4d09 (diff) | |
bio-integrity: Fix bio_integrity_verify segment start bug
This patch addresses a bug in bio_integrity_verify() code that has
been causing DIF READ verify operations to be silently skipped.
The issue is that bio->bi_idx will have been incremented within
bio_advance() code in the normal blk_update_request() ->
req_bio_endio() completion path, and bio_integrity_verify() is
using bio_for_each_segment() which starts the bio segment walk
at the current bio->bi_idx.
So instead use bio_for_each_segment_all() to always start the bio
segment walk from zero, regardless of the current bio->bi_idx
value after bio_advance() has been called.
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: stable@kernel.dk # >= v3.10
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/scsi_ioctl.c')
0 files changed, 0 insertions, 0 deletions