diff options
| author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2014-02-06 12:04:28 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-20 11:10:09 -0800 |
| commit | ca3b5b2dfbe20de81ede6b95cd21ca4ebed272ea (patch) | |
| tree | 828d7eda6e3f07063547f753771b5fac218afc10 /arch/x86/kernel/doublefault.c | |
| parent | 27b4328e523b3de854229e6b505f94aa9708dde6 (diff) | |
mm: __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq
commit 227d53b397a32a7614667b3ecaf1d89902fb6c12 upstream.
To use spin_{un}lock_irq is dangerous if caller disabled interrupt.
During aio buffer migration, we have a possibility to see the following
call stack.
aio_migratepage [disable interrupt]
migrate_page_copy
clear_page_dirty_for_io
set_page_dirty
__set_page_dirty_buffers
__set_page_dirty
spin_lock_irq
This mean, current aio migration is a deadlockable. spin_lock_irqsave
is a safer alternative and we should use it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reported-by: David Rientjes rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/x86/kernel/doublefault.c')
0 files changed, 0 insertions, 0 deletions