aboutsummaryrefslogtreecommitdiff
path: root/arch/powerpc/boot/dts/mpc8610_hpcd.dts
diff options
context:
space:
mode:
authorTom Alsberg <alsbergt@cs.huji.ac.il>2007-05-08 07:30:31 -0700
committerWilly Tarreau <w@1wt.eu>2007-09-23 11:22:24 +0200
commit652a44b1e452415b75713224b6df4d26a7b4e5a0 (patch)
tree680004c60984f951f7a20c2599c553654eb39160 /arch/powerpc/boot/dts/mpc8610_hpcd.dts
parent0d4a39318e6177ed424e92fe9ea75b514e782cdc (diff)
CPU time limit patch / setrlimit(RLIMIT_CPU, 0) cheat fix
CPU time limit patch / setrlimit(RLIMIT_CPU, 0) cheat fix As discovered here today, the change in Kernel 2.6.17 intended to inhibit users from setting RLIMIT_CPU to 0 (as that is equivalent to unlimited) by "cheating" and setting it to 1 in such a case, does not make a difference, as the check is done in the wrong place (too late), and only applies to the profiling code. On all systems I checked running kernels above 2.6.17, no matter what the hard and soft CPU time limits were before, a user could escape them by issuing in the shell (sh/bash/zsh) "ulimit -t 0", and then the user's process was not ever killed. Attached is a trivial patch to fix that. Simply moving the check to a slightly earlier location (specifically, before the line that actually assigns the limit - *old_rlim = new_rlim), does the trick. Do note that at least the zsh (but not ash, dash, or bash) shell has the problem of "caching" the limits set by the ulimit command, so when running zsh the fix will not immediately be evident - after entering "ulimit -t 0", "ulimit -a" will show "-t: cpu time (seconds) 0", even though the actual limit as returned by getrlimit(...) will be 1. It can be verified by opening a subshell (which will not have the values of the parent shell in cache) and checking in it, or just by running a CPU intensive command like "echo '65536^1048576' | bc" and verifying that it dumps core after one second. Regardless of whether that is a misfeature in the shell, perhaps it would be better to return -EINVAL from setrlimit in such a case instead of cheating and setting to 1, as that does not really reflect the actual state of the process anymore. I do not however know what the ground for that decision was in the original 2.6.17 change, and whether there would be any "backward" compatibility issues, so I preferred not to touch that right now. Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/powerpc/boot/dts/mpc8610_hpcd.dts')
0 files changed, 0 insertions, 0 deletions