diff options
| author | Jeff Garzik <jeff@garzik.org> | 2012-12-14 09:35:51 -0500 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2012-12-14 09:35:51 -0500 |
| commit | 11ace0c1defc4d1fe78afd29319bedef36da7078 (patch) | |
| tree | 669688b545614c0f2fb4edf271dd7d2b6ed2b64d | |
| parent | 8349e5aeaadd160b7cce554a62a05be4b2d894aa (diff) | |
Revert "pata_octeon_cf: perform host detach, removal on exit"
This reverts commit 1645bf1b51e5788a18cb6af7cfbb221ee17a6e8b.
Brian Norris writes:
> David Daney writes:
> I can seem to find it. Without knowing what that does, I would be inclined
> to NACK the whole thing.
A NACK is probably the right thing. I was mostly converting a few
other drivers which used some simple, common patterns to use my new
common code, but this driver was missing it altogether. It looks like
there may be bigger issues, though, as you point out.
> This patch is likely to be incomplete as the driver is also missing the
> module_exit() things.
>
> It might be simpler to just make the driver "bool" instead of "tristate" in
> the Kconfig.
As noted earlier, I don't have much interest in this driver. I agree
that there are some other issues with the driver; I think it leaks
memory if it is ever allowed to unload, for one. Feel free to submit
an alternative patch to prevent this driver from being built as a
module.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| -rw-r--r-- | drivers/ata/pata_octeon_cf.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c index d8df93b2a02..1d61d5d278f 100644 --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -921,7 +921,6 @@ free_cf_port: static struct platform_driver octeon_cf_driver = { .probe = octeon_cf_probe, - .remove = ata_platform_remove_one, .driver = { .name = DRV_NAME, .owner = THIS_MODULE, |