diff options
| author | Xi Wang <xi.wang@gmail.com> | 2013-01-04 03:22:57 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-01-16 01:13:19 +0000 |
| commit | 66ebe467a6dbbd0b3917ef6ad1bd4930f9b8185d (patch) | |
| tree | 0d629daaeac9721a933ae9709a96adbb5f807c2d | |
| parent | c69aab88b3a960f9d41a8d2c467eb61f613cbea7 (diff) | |
nfs: fix null checking in nfs_get_option_str()
commit e25fbe380c4e3c09afa98bcdcd9d3921443adab8 upstream.
The following null pointer check is broken.
*option = match_strdup(args);
return !option;
The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.
The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/nfs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 81503449f78..19438987bbe 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1057,7 +1057,7 @@ static int nfs_get_option_str(substring_t args[], char **option) { kfree(*option); *option = match_strdup(args); - return !option; + return !*option; } static int nfs_get_option_ul(substring_t args[], unsigned long *option) |