diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2006-06-03 02:00:33 +0200 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2006-06-05 10:18:15 -0700 |
| commit | fb0a8c49132586bfe44e437ccfae960ad7988fc8 (patch) | |
| tree | 819350050a5646bdbeef366baf7f941968d9910d | |
| parent | 9e5bd023df09e57692a87aba78d9ddee1888a559 (diff) | |
[PATCH] sbp2: fix check of return value of hpsb_allocate_and_register_addrspace
I added a failure check in patch "sbp2: variable status FIFO address
(fix login timeout)" --- alas for a wrong error value. This is a bug
since Linux 2.6.16. Leads to NULL pointer dereference if the call
failed, and bogus failure handling if call succeeded.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| -rw-r--r-- | drivers/ieee1394/sbp2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 1787104e517..d02be4ab011 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -764,7 +764,7 @@ static struct scsi_id_instance_data *sbp2_alloc_device(struct unit_directory *ud &sbp2_highlevel, ud->ne->host, &sbp2_ops, sizeof(struct sbp2_status_block), sizeof(quadlet_t), 0x010000000000ULL, CSR1212_ALL_SPACE_END); - if (!scsi_id->status_fifo_addr) { + if (scsi_id->status_fifo_addr == ~0ULL) { SBP2_ERR("failed to allocate status FIFO address range"); goto failed_alloc; } |