aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikanth Karthikesan <knikanth@suse.de>2010-05-16 14:00:00 -0400
committerPaul Gortmaker <paul.gortmaker@windriver.com>2011-01-06 18:07:36 -0500
commit508982ae874515f1adff7c650a6067a83f790b5f (patch)
tree3a4f131f525682f2c5a99bb333dda42f7c630c5b
parentff75dbcebeda9646e7f05e0b99ca715fe9f54870 (diff)
ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
commit 6d19c42b7cf81c39632b6d4dbc514e8449bcd346 upstream. Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit and create a file larger than the limit. Add a check for that. Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> Signed-off-by: Amit Arora <aarora@in.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--fs/ext4/extents.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ee611daf074..8a8f9f0be91 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3708,6 +3708,11 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
*/
credits = ext4_chunk_trans_blocks(inode, max_blocks);
mutex_lock(&inode->i_mutex);
+ ret = inode_newsize_ok(inode, (len + offset));
+ if (ret) {
+ mutex_unlock(&inode->i_mutex);
+ return ret;
+ }
retry:
while (ret >= 0 && ret < max_blocks) {
block = block + ret;