aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSrikar Dronamraju <srikar@linux.vnet.ibm.com>2010-06-29 23:02:26 +0530
committerIngo Molnar <mingo@elte.hu>2010-06-29 22:59:05 +0200
commit0879b100f3c187257729f36cba33d96ec2875766 (patch)
tree5efbc7a0beb5d3b4007ca7819b7eb64bf8e934ae
parent567a9fd86735ccdc897768ed2dacdd5e83a13509 (diff)
perf: Fix hist_entry__tui_annotate() build failure
When compiling perf on latest tip/master I see the following error: cc1: warnings being treated as errors util/newt.c: In function 'hist_entry__tui_annotate': util/newt.c:764: warning: 'ret' is used uninitialized in this function make: *** [util/newt.o] Error 1 I think the problem was introduced by commit 13f499f076c67675e6e3022973729b5d906a84e9 Below is a patch that fixes the problem. Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> LKML-Reference: <20100629173226.GC23231@linux.vnet.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--tools/perf/util/newt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
index 89c52fc9b22..06f248fde5c 100644
--- a/tools/perf/util/newt.c
+++ b/tools/perf/util/newt.c
@@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self)
browser.width += 18; /* Percentage */
ui_browser__show(&browser, self->ms.sym->name);
- ui_browser__run(&browser, &es);
+ ret = ui_browser__run(&browser, &es);
newtFormDestroy(browser.form);
newtPopWindow();
list_for_each_entry_safe(pos, n, &head, node) {