diff options
| author | Samuel Ortiz <samuel@sortiz.org> | 2010-10-06 01:03:12 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:26:32 -0800 |
| commit | 7a263a4d8dacd7cc9f1e90e1b6e9a2e16ea22031 (patch) | |
| tree | 61af1bc101a2f137f4088727d8d2b18aa73838dc | |
| parent | 3d72a94653ce5dbb54db04c3f60c840d1718265a (diff) | |
irda: Fix heap memory corruption in iriap.c
commit 37f9fc452d138dfc4da2ee1ce5ae85094efc3606 upstream.
While parsing the GetValuebyClass command frame, we could potentially write
passed the skb->data pointer.
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/irda/iriap.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/irda/iriap.c b/net/irda/iriap.c index 294e34d3517..f7d6150e090 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -501,7 +501,8 @@ static void iriap_getvaluebyclass_confirm(struct iriap_cb *self, IRDA_DEBUG(4, "%s(), strlen=%d\n", __func__, value_len); /* Make sure the string is null-terminated */ - fp[n+value_len] = 0x00; + if (n + value_len < skb->len) + fp[n + value_len] = 0x00; IRDA_DEBUG(4, "Got string %s\n", fp+n); /* Will truncate to IAS_MAX_STRING bytes */ |