diff options
| author | Tejun Heo <tj@kernel.org> | 2012-12-21 17:56:58 -0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2012-12-28 13:40:15 -0800 |
| commit | 6d394e192541a106bf78f361e2c4e586a8344e3e (patch) | |
| tree | 715db21226e29b60351bcc8f92a0ec89d0f1c524 | |
| parent | 7f5855c979ef0d49a8680b7fbdd3fc8e3093cb73 (diff) | |
thinkpad_acpi: don't use [delayed_]work_pending()
There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it. Most uses are unnecessary
and quite a few of them are buggy.
Remove unnecessary pending tests from thinkpad_acpi. Only compile
tested.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: ibm-acpi-devel@lists.sourceforge.net
Cc: platform-driver-x86@vger.kernel.org
| -rw-r--r-- | drivers/platform/x86/thinkpad_acpi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 75dd651664a..8421d1e7e47 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -4877,8 +4877,7 @@ static int __init light_init(struct ibm_init_struct *iibm) static void light_exit(void) { led_classdev_unregister(&tpacpi_led_thinklight.led_classdev); - if (work_pending(&tpacpi_led_thinklight.work)) - flush_workqueue(tpacpi_wq); + flush_workqueue(tpacpi_wq); } static int light_read(struct seq_file *m) |