diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2009-04-15 01:39:03 +0100 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2009-04-27 10:37:01 -0700 |
| commit | 926e66275ddb852a4a4686df9b6b0f760746c7a3 (patch) | |
| tree | 1428aa80a492cf929cad2a226d32313813318b22 | |
| parent | 9feb2c00e5d5b267912846454d7d0c85b6abd434 (diff) | |
sfc: Match calls to netif_napi_add() and netif_napi_del()
upstream commit: 718cff1eec595ce6ab0635b8160a51ee37d9268d
sfc could call netif_napi_add() multiple times for the same
napi_struct, corrupting the list of napi_structs for the associated
device and leading to a busy-loop on device removal. Move the call to
netif_napi_add() and add a call to netif_napi_del() in the obvious
places.
[bhutchings: backport to 2.6.29]
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| -rw-r--r-- | drivers/net/sfc/efx.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c index ab0e09bf154..655e9b253ab 100644 --- a/drivers/net/sfc/efx.c +++ b/drivers/net/sfc/efx.c @@ -424,10 +424,6 @@ static void efx_start_channel(struct efx_channel *channel) EFX_LOG(channel->efx, "starting chan %d\n", channel->channel); - if (!(channel->efx->net_dev->flags & IFF_UP)) - netif_napi_add(channel->napi_dev, &channel->napi_str, - efx_poll, napi_weight); - /* The interrupt handler for this channel may set work_pending * as soon as we enable it. Make sure it's cleared before * then. Similarly, make sure it sees the enabled flag set. */ @@ -1273,6 +1269,8 @@ static int efx_init_napi(struct efx_nic *efx) efx_for_each_channel(channel, efx) { channel->napi_dev = efx->net_dev; + netif_napi_add(channel->napi_dev, &channel->napi_str, + efx_poll, napi_weight); rc = efx_lro_init(&channel->lro_mgr, efx); if (rc) goto err; @@ -1289,6 +1287,8 @@ static void efx_fini_napi(struct efx_nic *efx) efx_for_each_channel(channel, efx) { efx_lro_fini(&channel->lro_mgr); + if (channel->napi_dev) + netif_napi_del(&channel->napi_str); channel->napi_dev = NULL; } } |