aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2010-11-15 11:35:49 -0800
committerGreg Kroah-Hartman <gregkh@suse.de>2010-12-09 13:26:57 -0800
commit0658f4b5ff80df551c5411f2a9a448f62664d2dc (patch)
tree17cf80e1402d6811219ab5ec2acbe5acc42aaa3b
parentd9d7d5f7290a7882b4b388b739af284bdb986b17 (diff)
USB: misc: usbled: fix up some sysfs attribute permissions
commit 48f115470e68d443436b76b22dad63ffbffd6b97 upstream. They should not be writable by any user. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/misc/usbled.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/misc/usbled.c b/drivers/usb/misc/usbled.c
index 06cb71942dc..9650de93a3d 100644
--- a/drivers/usb/misc/usbled.c
+++ b/drivers/usb/misc/usbled.c
@@ -94,7 +94,7 @@ static ssize_t set_##value(struct device *dev, struct device_attribute *attr, co
change_color(led); \
return count; \
} \
-static DEVICE_ATTR(value, S_IWUGO | S_IRUGO, show_##value, set_##value);
+static DEVICE_ATTR(value, S_IRUGO | S_IWUSR, show_##value, set_##value);
show_set(blue);
show_set(red);
show_set(green);