diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-09-10 01:56:16 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-09-26 17:21:24 -0700 |
| commit | ab0b42d8a04ce4c767c5c39a1cab1ef1a8289905 (patch) | |
| tree | 55811e33b790a1ca947c2d44f5d00ca2156327c9 | |
| parent | e220aa2dd5c106fbeb97558d68475b84d8fbd12a (diff) | |
net/llc: make opt unsigned in llc_ui_setsockopt()
commit 339db11b219f36cf7da61b390992d95bb6b7ba2e upstream.
The members of struct llc_sock are unsigned so if we pass a negative
value for "opt" it can cause a sign bug. Also it can cause an integer
overflow when we multiply "opt * HZ".
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/llc/af_llc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 7aa4fd17010..2da8d14c28c 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -977,7 +977,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname, { struct sock *sk = sock->sk; struct llc_sock *llc = llc_sk(sk); - int rc = -EINVAL, opt; + unsigned int opt; + int rc = -EINVAL; lock_sock(sk); if (unlikely(level != SOL_LLC || optlen != sizeof(int))) |