diff options
| author | Piotr Haber <phaber@broadcom.com> | 2012-10-11 14:05:15 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-10-30 23:26:47 +0000 |
| commit | 3b3cbdb97533b1e47260a9dcb5fd9d7f4741de5c (patch) | |
| tree | c2385ab039664e69cbc275f4cf0aa2de2f7e35cb | |
| parent | 69ec78aa6ff687c99e50b4e769046abe42717dc7 (diff) | |
bcma: fix unregistration of cores
commit 1fffa905adffbf0d3767fc978ef09afb830275eb upstream.
When cores are unregistered, entries
need to be removed from cores list in a safe manner.
Reported-by: Stanislaw Gruszka <sgruszka@redhat.com>
Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Signed-off-by: Piotr Haber <phaber@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/bcma/main.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c index 10f92b371e5..7a987a7803c 100644 --- a/drivers/bcma/main.c +++ b/drivers/bcma/main.c @@ -124,9 +124,10 @@ static int bcma_register_cores(struct bcma_bus *bus) static void bcma_unregister_cores(struct bcma_bus *bus) { - struct bcma_device *core; + struct bcma_device *core, *tmp; - list_for_each_entry(core, &bus->cores, list) { + list_for_each_entry_safe(core, tmp, &bus->cores, list) { + list_del(&core->list); if (core->dev_registered) device_unregister(&core->dev); } |