diff options
| author | Thomas Graf <tgraf@suug.ch> | 2008-03-19 23:14:34 +0200 |
|---|---|---|
| committer | Adrian Bunk <bunk@kernel.org> | 2008-03-19 23:14:34 +0200 |
| commit | 363aae61f7124e3f4ecc19d150a69f701bc098fa (patch) | |
| tree | 797ca28f73094615bd9b75ad146114c200b2fe9b | |
| parent | 03b7f70b359bcf52ac57516d18fa0f956a5eacf7 (diff) | |
[DECNet] fib: Fix out of bound access of dn_fib_props[]
Fixes a typo which caused fib_props[] to have the wrong size
and makes sure the value used to index the array which is
provided by userspace via netlink is checked to avoid out of
bound access.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
| -rw-r--r-- | net/decnet/dn_fib.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c index 99bc061759c..72ecb660a7b 100644 --- a/net/decnet/dn_fib.c +++ b/net/decnet/dn_fib.c @@ -65,7 +65,7 @@ static struct { int error; u8 scope; -} dn_fib_props[RTA_MAX+1] = { +} dn_fib_props[RTN_MAX+1] = { [RTN_UNSPEC] = { .error = 0, .scope = RT_SCOPE_NOWHERE }, [RTN_UNICAST] = { .error = 0, .scope = RT_SCOPE_UNIVERSE }, [RTN_LOCAL] = { .error = 0, .scope = RT_SCOPE_HOST }, @@ -275,6 +275,9 @@ struct dn_fib_info *dn_fib_create_info(const struct rtmsg *r, struct dn_kern_rta struct dn_fib_info *ofi; int nhs = 1; + if (r->rtm_type > RTN_MAX) + goto err_inval; + if (dn_fib_props[r->rtm_type].scope > r->rtm_scope) goto err_inval; |