diff options
| author | Hugh Dickins <hugh@veritas.com> | 2008-06-05 15:09:02 +0100 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2008-06-09 11:27:06 -0700 |
| commit | fd22beb45137e0920e34b03f9067c59a16350669 (patch) | |
| tree | a2e1ea9a28c0eeeba748e73e4b2f05d17c9b11f9 | |
| parent | 8dbac2301d9dae0646f7b87e62f8cdee9a6e208b (diff) | |
x86: fix bad pmd ffff810000207xxx(9090909090909090)
upstream commit: 2884f110d5409714f3a04eeb6d2ecd77da66b242
OGAWA Hirofumi and Fede have reported rare pmd_ERROR messages:
mm/memory.c:127: bad pmd ffff810000207xxx(9090909090909090).
Initialization's cleanup_highmap was leaving alignment filler
behind in the pmd for MODULES_VADDR: when vmalloc's guard page
would occupy a new page table, it's not allocated, and then
module unload's vfree hits the bad 9090 pmd entry left over.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Hugh notes:
It's actually not a serious problem, but it does look as if it's a
serious problem, so we should stamp it out.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| -rw-r--r-- | arch/x86/mm/init_64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index a02a14f0f32..b2c5231c468 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -192,7 +192,7 @@ void __init cleanup_highmap(void) pmd_t *last_pmd = pmd + PTRS_PER_PMD; for (; pmd < last_pmd; pmd++, vaddr += PMD_SIZE) { - if (!pmd_present(*pmd)) + if (pmd_none(*pmd)) continue; if (vaddr < (unsigned long) _text || vaddr > end) set_pmd(pmd, __pmd(0)); |