diff options
| author | Gleb Natapov <gleb@redhat.com> | 2012-12-12 19:10:49 +0200 |
|---|---|---|
| committer | Gleb Natapov <gleb@redhat.com> | 2012-12-23 14:00:36 +0200 |
| commit | 07f42f5f25dc214a33214159fc8b62b984b713eb (patch) | |
| tree | 502bece6c0a8dc7da1bd668b49493681787a8941 | |
| parent | 116c14c0191f3378e6567af296529ac287e85aa2 (diff) | |
KVM: VMX: cleanup rmode_segment_valid()
Set segment fields explicitly instead of using binary operations.
No behaviour changes.
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
| -rw-r--r-- | arch/x86/kvm/vmx.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index b3101e36807..265fdd37b24 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3380,13 +3380,16 @@ static bool rmode_segment_valid(struct kvm_vcpu *vcpu, int seg) u32 ar; vmx_get_segment(vcpu, &var, seg); + var.dpl = 0x3; + var.g = 0; + var.db = 0; ar = vmx_segment_access_rights(&var); if (var.base != (var.selector << 4)) return false; if (var.limit < 0xffff) return false; - if (((ar | (3 << AR_DPL_SHIFT)) & ~(AR_G_MASK | AR_DB_MASK)) != 0xf3) + if (ar != 0xf3) return false; return true; |