diff options
| author | Jeff Mahoney <jeffm@suse.com> | 2009-05-11 14:25:34 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-05-19 22:20:07 -0700 |
| commit | bdc9a1caa2fae65d8b323c312f73b40d30ff4dae (patch) | |
| tree | f973a80fa04e23c1bd554e7a455086aa1536b5a0 /.gitignore | |
| parent | 091fc4290d9d7c3bc56e0685f3b3baf8f80613f1 (diff) | |
dup2: Fix return value with oldfd == newfd and invalid fd
commit 2b79bc4f7ebbd5af3c8b867968f9f15602d5f802 upstream.
The return value of dup2 when oldfd == newfd and the fd isn't valid is
not getting properly sign extended. We end up with 4294967287 instead
of -EBADF.
I've reproduced this on SLE11 (2.6.27.21), openSUSE Factory
(2.6.29-rc5), and Ubuntu 9.04 (2.6.28).
This patch uses a signed int for the error value so it is properly
extended.
Commit 6c5d0512a091480c9f981162227fdb1c9d70e555 introduced this
regression.
Reported-by: Jiri Dluhos <jdluhos@novell.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions