linux/net/sunrpc, branch v2.6.20.3

RPM: fix double free in portmapper code

2007-03-09T18:50:29Z

rpc_run_task is guaranteed to always call ->rpc_release. Signed-off-by: Trond Myklebust Cc: Neil Brown Cc: Jan "Yenya" Kasprzak Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman

Fix recently introduced problem with shutting down a busy NFS server.

2007-03-09T18:50:21Z

When the last thread of nfsd exits, it shuts down all related sockets. It currently uses svc_close_socket to do this, but that only is immediately effective if the socket is not SK_BUSY. If the socket is busy - i.e. if a request has arrived that has not yet been processes - svc_close_socket is not effective and the shutdown process spins. So create a new svc_force_close_socket which removes the SK_BUSY flag is set and then calls svc_close_socket. Also change some open-codes loops in svc_destroy to use list_for_each_entry_safe. Signed-off-by: Neil Brown Signed-off-by: Greg Kroah-Hartman

Avoid using nfsd process pools on SMP machines.

2007-03-09T18:50:21Z

process-pools have real benefits for NUMA, but on SMP machines they only work if network interface interrupts go to all CPUs (via round-robin or multiple nics). This is not always the case, so disable the pools in this case until a better solution is developped. Signed-off-by: Neil Brown Signed-off-by: Greg Kroah-Hartman diff .prev/net/sunrpc/svc.c ./net/sunrpc/svc.c

knfsd: Fix a race in closing NFSd connections.

2007-03-09T18:50:18Z

If you lose this race, it can iput a socket inode twice and you get a BUG in fs/inode.c When I added the option for user-space to close a socket, I added some cruft to svc_delete_socket so that I could call that function when closing a socket per user-space request. This was the wrong thing to do. I should have just set SK_CLOSE and let normal mechanisms do the work. Not only wrong, but buggy. The locking is all wrong and it openned up a race where-by a socket could be closed twice. So this patch: Introduces svc_close_socket which sets SK_CLOSE then either leave the close up to a thread, or calls svc_delete_socket if it can get SK_BUSY. Adds a bias to sk_busy which is removed when SK_DEAD is set, This avoid races around shutting down the socket. Changes several 'spin_lock' to 'spin_lock_bh' where the _bh was missing. Bugzilla-url: http://bugzilla.kernel.org/show_bug.cgi?id=7916 Signed-off-by: Neil Brown Signed-off-by: Greg Kroah-Hartman

[PATCH] knfsd: ratelimit some nfsd messages that are triggered by external events

2007-01-30T16:26:45Z

Also remove {NFSD,RPC}_PARANOIA as having the defines doesn't really add anything. The printks covered by RPC_PARANOIA were triggered by badly formatted packets and so should be ratelimited. Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] knfsd: fix an NFSD bug with full sized, non-page-aligned reads

2007-01-26T21:50:59Z

NFSd assumes that largest number of pages that will be needed for a request+response is 2+N where N pages is the size of the largest permitted read/write request. The '2' are 1 for the non-data part of the request, and 1 for the non-data part of the reply. However, when a read request is not page-aligned, and we choose to use ->sendfile to send it directly from the page cache, we may need N+1 pages to hold the whole reply. This can overflow and array and cause an Oops. This patch increases size of the array for holding pages by one and makes sure that entry is NULL when it is not in use. Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] knfsd: fix setting of ACL server versions

2007-01-26T21:50:59Z

Due to silly typos, if the nfs versions are explicitly set, no NFSACL versions get enabled. Also improve an error message that would have made this bug a little easier to find. Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] NFS: Fix Oops in rpc_call_sync()

2007-01-24T20:31:06Z

Fix the Oops in http://bugzilla.linux-nfs.org/show_bug.cgi?id=138 We shouldn't be calling rpc_release_task() for tasks that are not active. Signed-off-by: Trond Myklebust Signed-off-by: Linus Torvalds

[PATCH] gss_spkm3: fix error handling in module init

2006-12-22T16:55:49Z

Return error and prevent from loading module when gss_mech_register() failed. Cc: Andy Adamson Cc: J. Bruce Fields Acked-by: Trond Myklebust Signed-off-by: Akinobu Mita Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] knfsd: Don't ignore kstrdup failure in rpc caches

2006-12-13T17:05:54Z

Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds