<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux/net/ipv4/ping.c, branch v3.3.5</title>
<subtitle>Linux kernel source tree</subtitle>
<id>https://git.amat.us/linux/atom/net/ipv4/ping.c?h=v3.3.5</id>
<link rel='self' href='https://git.amat.us/linux/atom/net/ipv4/ping.c?h=v3.3.5'/>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/'/>
<updated>2012-02-21T22:59:19Z</updated>
<entry>
<title>ipv4: ping: Fix recvmsg MSG_OOB error handling.</title>
<updated>2012-02-21T22:59:19Z</updated>
<author>
<name>David S. Miller</name>
<email>davem@davemloft.net</email>
</author>
<published>2012-02-21T22:59:19Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=a5e7424d424f6398a198ead79d99e0a3c2f24ce8'/>
<id>urn:sha1:a5e7424d424f6398a198ead79d99e0a3c2f24ce8</id>
<content type='text'>
Don't return an uninitialized variable as the error, return
-EOPNOTSUPP instead.

Reported-by: Dave Jones &lt;davej@redhat.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: fix some sparse errors</title>
<updated>2012-01-17T15:31:12Z</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2012-01-16T19:27:39Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=747465ef7a082033e086dedc8189febfda43b015'/>
<id>urn:sha1:747465ef7a082033e086dedc8189febfda43b015</id>
<content type='text'>
make C=2 CF="-D__CHECK_ENDIAN__" M=net

And fix flowi4_init_output() prototype for sport

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>ping: dont increment ICMP_MIB_INERRORS</title>
<updated>2011-11-18T19:38:59Z</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2011-11-17T04:40:20Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=fb120c0a2775b0d2d095a99ea8432bfb5d444ab2'/>
<id>urn:sha1:fb120c0a2775b0d2d095a99ea8432bfb5d444ab2</id>
<content type='text'>
ping module incorrectly increments ICMP_MIB_INERRORS if feeded with a
frame not belonging to its own sockets.

RFC 2011 states that ICMP_MIB_INERRORS should count "the number of ICMP
messages which the entiry received but determined as having
ICMP-specific errors (bad ICMP checksums, bad length, etc.)."

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
CC: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Acked-by: Flavio Leitner &lt;fbl@redhat.com&gt;
Acked-by: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules</title>
<updated>2011-10-31T23:30:30Z</updated>
<author>
<name>Paul Gortmaker</name>
<email>paul.gortmaker@windriver.com</email>
</author>
<published>2011-07-15T15:47:34Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=bc3b2d7fb9b014d75ebb79ba371a763dbab5e8cf'/>
<id>urn:sha1:bc3b2d7fb9b014d75ebb79ba371a763dbab5e8cf</id>
<content type='text'>
These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.

Signed-off-by: Paul Gortmaker &lt;paul.gortmaker@windriver.com&gt;
</content>
</entry>
<entry>
<title>ipv4, ping: Remove duplicate icmp.h include</title>
<updated>2011-06-20T20:04:38Z</updated>
<author>
<name>Jesper Juhl</name>
<email>jj@chaosbits.net</email>
</author>
<published>2011-06-19T22:31:20Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=8ad2475e3555346fbd738e77da12578b97d10505'/>
<id>urn:sha1:8ad2475e3555346fbd738e77da12578b97d10505</id>
<content type='text'>
Remove the duplicate inclusion of net/icmp.h from net/ipv4/ping.c

Signed-off-by: Jesper Juhl &lt;jj@chaosbits.net&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: ping: cleanups ping_v4_unhash()</title>
<updated>2011-05-23T20:29:24Z</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2011-05-22T22:23:00Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=19a76fa9593bad778dabeeec1f6c2df6effe9ca3'/>
<id>urn:sha1:19a76fa9593bad778dabeeec1f6c2df6effe9ca3</id>
<content type='text'>
net/ipv4/ping.c: In function ‘ping_v4_unhash’:
net/ipv4/ping.c:140:28: warning: variable ‘hslot’ set but not used

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
CC: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Acked-by: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: ping: fix the coding style</title>
<updated>2011-05-19T20:17:51Z</updated>
<author>
<name>Changli Gao</name>
<email>xiaosuo@gmail.com</email>
</author>
<published>2011-05-18T21:16:01Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=75e308c894c4a5e47c005b8e821ae5f539ad2ef3'/>
<id>urn:sha1:75e308c894c4a5e47c005b8e821ae5f539ad2ef3</id>
<content type='text'>
The characters in a line should be no more than 80.

Signed-off-by: Changli Gao &lt;xiaosuo@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: ping: make local functions static</title>
<updated>2011-05-19T20:17:51Z</updated>
<author>
<name>Changli Gao</name>
<email>xiaosuo@gmail.com</email>
</author>
<published>2011-05-18T21:16:00Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=bb0cd2fb539c4e454ed32e32194acc03b75753f3'/>
<id>urn:sha1:bb0cd2fb539c4e454ed32e32194acc03b75753f3</id>
<content type='text'>
As these functions are only used in this file.

Signed-off-by: Changli Gao &lt;xiaosuo@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: ping: fix build failure</title>
<updated>2011-05-17T18:16:58Z</updated>
<author>
<name>Vasiliy Kulikov</name>
<email>segoon@openwall.com</email>
</author>
<published>2011-05-17T00:16:56Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=f56e03e8dc149bf0ac2888d6843584f48c8700fc'/>
<id>urn:sha1:f56e03e8dc149bf0ac2888d6843584f48c8700fc</id>
<content type='text'>
If CONFIG_PROC_SYSCTL=n the building process fails:

    ping.c:(.text+0x52af3): undefined reference to `inet_get_ping_group_range_net'

Moved inet_get_ping_group_range_net() to ping.c.

Reported-by: Randy Dunlap &lt;randy.dunlap@oracle.com&gt;
Signed-off-by: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Acked-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
Acked-by: Randy Dunlap &lt;randy.dunlap@oracle.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>net: ping: dont call udp_ioctl()</title>
<updated>2011-05-16T15:49:39Z</updated>
<author>
<name>Eric Dumazet</name>
<email>eric.dumazet@gmail.com</email>
</author>
<published>2011-05-15T21:26:31Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=1a8218e96271790a07dd7065a2ef173e0f67e328'/>
<id>urn:sha1:1a8218e96271790a07dd7065a2ef173e0f67e328</id>
<content type='text'>
udp_ioctl() really handles UDP and UDPLite protocols.

1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds
a frame with bad checksum.

2) It has a dependency on sizeof(struct udphdr), not applicable to
ICMP/PING

If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be
done differently.

Signed-off-by: Eric Dumazet &lt;eric.dumazet@gmail.com&gt;
CC: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Acked-by: Vasiliy Kulikov &lt;segoon@openwall.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
</feed>
