linux/fs/hfsplus/wrapper.c, branch v3.4.92

hfsplus: fix overflow in sector calculations in hfsplus_submit_bio

2012-06-22T18:36:57Z

commit a6dc8c04218eb752ff79cdc24a995cf51866caed upstream. The variable io_size was unsigned int, which caused the wrong sector number to be calculated after aligning it. This then caused mount to fail with big volumes, as backup volume header information was searched from a wrong sector. Signed-off-by: Janne Kalliomäki Signed-off-by: Christoph Hellwig Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman

hfsplus: Fix kfree of wrong pointers in hfsplus_fill_super() error path

2011-09-15T16:03:16Z

Commit 6596528e391a ("hfsplus: ensure bio requests are not smaller than the hardware sectors") changed the pointers used for volume header allocations but failed to free the correct pointers in the error path path of hfsplus_fill_super() and hfsplus_read_wrapper. The second hunk came from a separate patch by Pavel Ivanov. Reported-by: Pavel Ivanov Signed-off-by: Seth Forshee Signed-off-by: Christoph Hellwig Cc: Signed-off-by: Linus Torvalds

hfsplus: ensure bio requests are not smaller than the hardware sectors

2011-07-22T14:37:44Z

Currently all bio requests are 512 bytes, which may fail for media whose physical sector size is larger than this. Ensure these requests are not smaller than the block device logical block size. BugLink: http://bugs.launchpad.net/bugs/734883 Signed-off-by: Seth Forshee Signed-off-by: Christoph Hellwig

hfsplus: lift the 2TB size limit

2011-06-30T11:40:59Z

Replace the hardcoded 2TB limit with a dynamic limit based on the block size now that we have fixed the few overflows preventing operation with large volumes. Signed-off-by: Christoph Hellwig

hfsplus: fix overflow in hfsplus_read_wrapper

2011-06-30T11:40:59Z

For partitions larger than 2TB or at such an offset the hfs wrapper code in hfsplus might overflow the range representable in a 32-bit data type. Make sure we use a sector_t for the arithmetics leading to it. I'm not sure this code can be readed at all as hfs itself never supported such large volumes. Signed-off-by: Christoph Hellwig

hfsplus: add missing call to bio_put()

2011-06-30T11:28:32Z

hfsplus leaks bio objects by failing to call bio_put() on the bios it allocates. Add the missing call to fix the leak. Signed-off-by: Seth Forshee Cc: # .38.x, .39.x Signed-off-by: Christoph Hellwig

hfsplus: fix two memory leaks in wrapper.c

2011-02-03T23:34:11Z

Signed-Off-By: Chuck Ebbert Signed-off-by: Christoph Hellwig

hfsplus: over 80 character lines clean-up

2010-12-16T17:08:45Z

Match coding style line length limitation where checkpatch.pl reported over-80-character-line warnings. Signed-off-by: Anton Salikhmetov Signed-off-by: Christoph Hellwig

hfsplus: use raw bio access for the volume headers

2010-11-23T13:37:47Z

The hfsplus backup volume header is located two blocks from the end of the device. In case of device sizes that are not 4k aligned this means we can't access it using buffer_heads when using the default 4k block size. Switch to using raw bios to read/write all buffer headers. We were not relying on any caching behaviour of the buffer heads anyway. Additionally always read in the backup volume header during mount to verify that we can actually read it. Signed-off-by: Christoph Hellwig

hfsplus: use atomic bitops for the superblock flags

2010-10-01T03:45:20Z

The flags in the HFS+-specific superlock do get modified during runtime, use atomic bitops to make the modifications SMP safe. Signed-off-by: Christoph Hellwig