<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux/drivers/usb/serial/console.c, branch v3.2.23</title>
<subtitle>Linux kernel source tree</subtitle>
<id>https://git.amat.us/linux/atom/drivers/usb/serial/console.c?h=v3.2.23</id>
<link rel='self' href='https://git.amat.us/linux/atom/drivers/usb/serial/console.c?h=v3.2.23'/>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/'/>
<updated>2010-05-20T20:21:32Z</updated>
<entry>
<title>usb-console: pass baud from console to the initial tty open</title>
<updated>2010-05-20T20:21:32Z</updated>
<author>
<name>Jason Wessel</name>
<email>jason.wessel@windriver.com</email>
</author>
<published>2010-03-16T21:05:44Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=92d2c5e4badc622999d3b17e6dfbf6babacb52f6'/>
<id>urn:sha1:92d2c5e4badc622999d3b17e6dfbf6babacb52f6</id>
<content type='text'>
The usb console code has had a long standing problem of not being able
to pass the baud rate from the kernel argument console=ttyUSB0,BAUD
down to the initial tty open, unless you were willing to settle for
9600 baud.

The solution is to directly use tty_init_termios() in
usb_console_setup() as this will preserve any changes to the initial
termios setting on future opens.

CC: Alan Cox &lt;alan@linux.intel.com&gt;
CC: Alan Stern &lt;stern@rowland.harvard.edu&gt;
Signed-off-by: Jason Wessel &lt;jason.wessel@windriver.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
</entry>
<entry>
<title>usb-serial: Use tty_port version console instead of usb_serial_port</title>
<updated>2010-05-20T20:21:31Z</updated>
<author>
<name>Jason Wessel</name>
<email>jason.wessel@windriver.com</email>
</author>
<published>2010-03-09T03:50:12Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=bd5afa9eac6daa408412a31a6c69e87e8bd28c7e'/>
<id>urn:sha1:bd5afa9eac6daa408412a31a6c69e87e8bd28c7e</id>
<content type='text'>
Replace all instances of using the console variable in struct
usb_serial_port with the struct tty_port version.

CC: Alan Cox &lt;alan@linux.intel.com&gt;
CC: Alan Stern &lt;stern@rowland.harvard.edu&gt;
CC: Oliver Neukum &lt;oliver@neukum.org&gt;
CC: Andrew Morton &lt;akpm@linux-foundation.org&gt;
CC: linux-usb@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Jason Wessel &lt;jason.wessel@windriver.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
</entry>
<entry>
<title>tty_port,usb-console: Fix usb serial console open/close regression</title>
<updated>2010-03-19T14:17:57Z</updated>
<author>
<name>Jason Wessel</name>
<email>jason.wessel@windriver.com</email>
</author>
<published>2010-03-09T03:50:11Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=336cee42dd52824e360ab419eab4e8888eb054ec'/>
<id>urn:sha1:336cee42dd52824e360ab419eab4e8888eb054ec</id>
<content type='text'>
Commit e1108a63e10d344284011cccc06328b2cd3e5da3 ("usb_serial: Use the
shutdown() operation") breaks the ability to use a usb console
starting in 2.6.33.  This was observed when using
console=ttyUSB0,115200 as a boot argument with an FTDI device.  The
error is:

ftdi_sio ttyUSB0: ftdi_submit_read_urb - failed submitting read urb, error -22

The handling of the ASYNCB_INITIALIZED changed in 2.6.32 such that in
tty_port_shutdown() it always clears the flag if it is set.  The fix
is to add a variable to the tty_port struct to indicate when the tty
port is a console.

CC: Alan Cox &lt;alan@linux.intel.com&gt;
CC: Alan Stern &lt;stern@rowland.harvard.edu&gt;
CC: Oliver Neukum &lt;oliver@neukum.org&gt;
CC: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Jason Wessel &lt;jason.wessel@windriver.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
</entry>
<entry>
<title>USB serial: update the console driver</title>
<updated>2009-09-19T20:13:42Z</updated>
<author>
<name>Alan Stern</name>
<email>stern@rowland.harvard.edu</email>
</author>
<published>2009-09-04T19:29:59Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=7bd032dc2793afcbaf4a350056768da84cdbd89b'/>
<id>urn:sha1:7bd032dc2793afcbaf4a350056768da84cdbd89b</id>
<content type='text'>
This patch (as1292) modifies the USB serial console driver, to make it
compatible with the recent changes to the USB serial core.  The most
important change is that serial-&gt;disc_mutex now has to be unlocked
following a successful call to usb_serial_get_by_index().

Other less notable changes include:

	Use the requested port number instead of port 0 always.

	Prevent the serial device from being autosuspended.

	Use the ASYNCB_INITIALIZED flag bit to indicate when the
	port hardware has been initialized.

In spite of these changes, there's no question that the USB serial
console code is still a big hack.

Signed-off-by: Alan Stern &lt;stern@rowland.harvard.edu&gt;
Cc: stable &lt;stable@kernel.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
</entry>
<entry>
<title>tty: USB does not need the filp argument in the drivers</title>
<updated>2009-09-19T20:13:26Z</updated>
<author>
<name>Alan Cox</name>
<email>alan@linux.intel.com</email>
</author>
<published>2009-09-19T20:13:26Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=a509a7e478e4766114d69f12d19d644ac63e9765'/>
<id>urn:sha1:a509a7e478e4766114d69f12d19d644ac63e9765</id>
<content type='text'>
And indeed none of them use it. Clean this up as it will make moving to a
standard open method rather easier.

Signed-off-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</content>
</entry>
<entry>
<title>USB: console: Fix regression in usb console on kernel boot</title>
<updated>2009-07-12T22:16:39Z</updated>
<author>
<name>Jason Wessel</name>
<email>jason.wessel@windriver.com</email>
</author>
<published>2009-06-22T16:32:20Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=6e4061210150d1d6d388c5fba05f6b49a306a27e'/>
<id>urn:sha1:6e4061210150d1d6d388c5fba05f6b49a306a27e</id>
<content type='text'>
The commit 335f8514f200e63d689113d29cb7253a5c282967 introduced a
regression which stopped usb consoles from working correctly as a
kernel boot console as well as interactive login device.

The addition of the serial_close() which in turn calls
tty_port_close_start() will change the reference count of port.count
and warn about it.  The usb console code had previously incremented
the port.count to indicate it was making use of the device as a
console and the forced change causes a double open on the usb device
which leads to a non obvious kernel oops later on when the tty is
freed.

To fix the problem instead make use of port-&gt;console to track if the
port is in fact an active console port to avoid double initialization
of the usb serial device.  The port.count is incremented and
decremented only with in the scope of usb_console_setup() for the
purpose of the low level driver initialization.

Signed-off-by: Jason Wessel &lt;jason.wessel@windriver.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
</entry>
<entry>
<title>tty: Bring the usb tty port structure into more use</title>
<updated>2009-06-11T15:50:56Z</updated>
<author>
<name>Alan Cox</name>
<email>alan@lxorguk.ukuu.org.uk</email>
</author>
<published>2009-06-11T11:26:29Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=335f8514f200e63d689113d29cb7253a5c282967'/>
<id>urn:sha1:335f8514f200e63d689113d29cb7253a5c282967</id>
<content type='text'>
This allows us to clean stuff up, but is probably also going to cause
some app breakage with buggy apps as we now implement proper POSIX behaviour
for USB ports matching all the other ports. This does also mean other apps
that break on USB will now work properly.

Signed-off-by: Alan Cox &lt;alan@lxorguk.ukuu.org.uk&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
<entry>
<title>Add device function for USB serial console</title>
<updated>2009-01-02T18:19:38Z</updated>
<author>
<name>Kevin Hao</name>
<email>kexin.hao@windriver.com</email>
</author>
<published>2009-01-02T13:44:34Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=39efd191d01b5f1efc3d604baf74233dc525e6a8'/>
<id>urn:sha1:39efd191d01b5f1efc3d604baf74233dc525e6a8</id>
<content type='text'>
Add device funtion for usb serial console, so we can open /dev/console
when we use a usb serial device as console.

(Typecast removed as noted by Sergei Shtylyov)

Signed-off-by: Kevin Hao &lt;kexin.hao@windriver.com&gt;
Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
<entry>
<title>Add kref to fake tty used by USB console</title>
<updated>2008-12-01T16:19:10Z</updated>
<author>
<name>Kevin Hao</name>
<email>kexin.hao@windriver.com</email>
</author>
<published>2008-12-01T11:36:16Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=e5404586a499f7dce915456e85ff94b2df7a3b1c'/>
<id>urn:sha1:e5404586a499f7dce915456e85ff94b2df7a3b1c</id>
<content type='text'>
We alloc a fake tty in usb serial console setup function. we should
init the tty's kref otherwise we will face WARN_ON after following
invoke of tty_port_tty_set --&gt; tty_kref_get.

Signed-off-by: Kevin Hao &lt;kexin.hao@windriver.com&gt;
Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
<entry>
<title>tty: usb-serial krefs</title>
<updated>2008-10-13T16:51:41Z</updated>
<author>
<name>Alan Cox</name>
<email>alan@redhat.com</email>
</author>
<published>2008-10-13T09:39:46Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=4a90f09b20f4622dcbff1f0e1e6bae1704f8ad8c'/>
<id>urn:sha1:4a90f09b20f4622dcbff1f0e1e6bae1704f8ad8c</id>
<content type='text'>
Use kref in the USB serial drivers so that we don't free tty structures
from under the URB receive handlers as has historically been the case if
you were unlucky. This also gives us a framework for general tty drivers to
use tty_port objects and refcount.

Contains two err-&gt;dev_err changes merged together to fix clashes in the
-next tree.

Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
</feed>
