Linux kernel source tree https://git.amat.us/linux/atom/drivers/usb/dwc3/debugfs.c?h=v3.4.2 2012-02-10T10:14:53Z 2012-02-10T10:14:53Z Gerard Cauvy g-cauvy1@ti.com 2012-02-10T10:14:53Z urn:sha1:090725431b9636a0a59516ff0fe94933cf09a82b When implementing the USB2 testmode support via debugfs, Felipe has committed a mistake when counting the number of letters of some of the strings, resulting on an off by one error which prevented some of the Test modes to be entered properly. This patch, fixes that mistake. Signed-off-by: Gerard Cauvy <g-cauvy1@ti.com> Signed-off-by: Felipe Balbi <balbi@ti.com> 2012-02-06T09:48:41Z Felipe Balbi balbi@ti.com 2012-01-31T11:33:32Z urn:sha1:3d4c0d4ffb418800b2d1af111f9e1d5b204ee55c debugfs APIs will return NULL if it fails to create the file/directory we ask it to create. Instead of checking for IS_ERR(ptr) we must check for !ptr. Signed-off-by: Felipe Balbi <balbi@ti.com> 2012-02-06T09:48:25Z Felipe Balbi balbi@ti.com 2012-01-02T17:25:16Z urn:sha1:138801aaa566ecb5a5739a85909b9ec7285efd70 This is very useful for low level link testing where we might not have a USB Host stack, only a scope to verify signal integrity. Signed-off-by: Felipe Balbi <balbi@ti.com> 2012-02-06T09:48:22Z Felipe Balbi balbi@ti.com 2012-01-02T16:38:30Z urn:sha1:080d921fe7a8d27c07eba7723fe53a3bea100327 This is very useful for low level Link Testing where we might not have a USB Host stack, only a scope to verify signal integrity. Signed-off-by: Felipe Balbi <balbi@ti.com> 2012-01-09T20:09:47Z Linus Torvalds torvalds@linux-foundation.org 2012-01-09T20:09:47Z urn:sha1:55b81e6f2795484ea8edf5805c95c007cacfa736 * 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (232 commits) USB: Add USB-ID for Multiplex RC serial adapter to cp210x.c xhci: Clean up 32-bit build warnings. USB: update documentation for usbmon usb: usb-storage doesn't support dynamic id currently, the patch disables the feature to fix an oops drivers/usb/class/cdc-acm.c: clear dangling pointer drivers/usb/dwc3/dwc3-pci.c: introduce missing kfree drivers/usb/host/isp1760-if.c: introduce missing kfree usb: option: add ZD Incorporated HSPA modem usb: ch9: fix up MaxStreams helper USB: usb-skeleton.c: cleanup open_count USB: usb-skeleton.c: fix open/disconnect race xhci: Properly handle COMP_2ND_BW_ERR USB: remove dead code from suspend/resume path USB: add quirk for another camera drivers: usb: wusbcore: Fix dependency for USB_WUSB xhci: Better debugging for critical host errors. xhci: Be less verbose during URB cancellation. xhci: Remove debugging about ring structure allocation. xhci: Remove debugging about toggling cycle bits. xhci: Remove debugging for individual transfers. ... 2011-12-12T09:48:29Z Felipe Balbi balbi@ti.com 2011-11-04T10:40:05Z urn:sha1:8becf2704415d2bf471a0a73ae84c3cc24da8a90 sparse caught three mistakes on this driver, fix them: drivers/usb/dwc3/ep0.c:806:29: warning: duplicate const drivers/usb/dwc3/debugfs.c:481:15: warning: symbol 'dwc3_debugfs_init' \ was not declared. Should it be static? drivers/usb/dwc3/debugfs.c:518:16: warning: symbol 'dwc3_debugfs_exit' \ was not declared. Should it be static? Signed-off-by: Felipe Balbi <balbi@ti.com> 2011-12-12T09:48:29Z Felipe Balbi balbi@ti.com 2011-11-04T10:32:47Z urn:sha1:25b8ff68bf1d4954d4a9dcb4862c6b6a53cb09e2 There were a few coding style issues with this driver which are now fixed: drivers/usb/dwc3/debugfs.c:48: WARNING: Use #include \ <linux/uaccess.h> instead of <asm/uaccess.h> drivers/usb/dwc3/debugfs.c:484: ERROR: space required \ before the open brace '{' drivers/usb/dwc3/ep0.c:261: WARNING: line over 80 characters drivers/usb/dwc3/ep0.c:287: WARNING: suspect code indent \ for conditional statements (16, 23) drivers/usb/dwc3/gadget.c:749: WARNING: line over 80 characters drivers/usb/dwc3/gadget.c:1267: WARNING: line over 80 characters drivers/usb/dwc3/gadget.h:116: WARNING: line over 80 characters drivers/usb/dwc3/io.h:42: WARNING: Use #include \ <linux/io.h> instead of <asm/io.h> Signed-off-by: Felipe Balbi <balbi@ti.com> 2011-12-12T09:48:26Z Sebastian Andrzej Siewior bigeasy@linutronix.de 2011-10-31T21:25:40Z urn:sha1:3140e8cbfec18ecb9c9ef856933fdb98c09af1e8 There are two where need to set operational mode: - during initialization while we decide to run in host,device or DRD mode - at runtime via the debugfs interface. This patch provides a new function which sets the operational mode and moves its initialiation to the mode switch instead in the gadget code itself. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com> 2011-12-12T09:48:19Z Sebastian Andrzej Siewior bigeasy@linutronix.de 2011-10-20T16:43:07Z urn:sha1:c5537ea531d83b7d02ce2d52a5e2b90f526449d0 The read and write operation is atomic and we need no locking around this operations. What we need however is a lock that is held which ensures that the content of the DWC3_GCTL has not been changed. With this, the conten may have been change changed after the first but before our write back. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com> 2011-12-12T09:48:15Z Felipe Balbi balbi@ti.com 2011-10-17T05:50:39Z urn:sha1:0b9fe32deece53c9bc6d1e6d17a85ef1eb2e294b This makes testing a lot easier when trying to switch between host and device modes. Signed-off-by: Felipe Balbi <balbi@ti.com>