Linux kernel source tree https://git.amat.us/linux/atom/drivers/mtd/tests?h=v3.4.2 2012-01-09T18:26:24Z 2012-01-09T18:26:24Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2012-01-02T11:48:54Z urn:sha1:8f461a730242c528ca221948edceca49266a3ffb This patch introduces new 'mtd_can_have_bb()' helper function which checks whether the flash can have bad eraseblocks. Then it changes all the direct 'mtd->block_isbad' use cases with 'mtd_can_have_bb()'. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:56Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-29T13:16:28Z urn:sha1:30fa98480b782999248ce8290136aa58f22536cf MTD functions always assign the 'retlen' argument to 0 at the very beginning - the callers do not have to do this. I used the following semantic patch to find these places: @@ identifier retlen; expression a, b, c, d, e; constant C; type T; @@ ( - retlen = C; | T -retlen = C + retlen ; ) ... when != retlen when exists ( mtd_read(a, b, c, &retlen, d) | mtd_write(a, b, c, &retlen, d) | mtd_panic_write(a, b, c, &retlen, d) | mtd_point(a, b, c, &retlen, d, e) | mtd_read_fact_prot_reg(a, b, c, &retlen, d) | mtd_write_user_prot_reg(a, b, c, &retlen, d) | mtd_read_user_prot_reg(a, b, c, &retlen, d) | mtd_writev(a, b, c, d, &retlen) ) I ran it twice, because there were cases of double zero assigments in mtd tests. Then I went through the patch to verify that spatch did not find any false positives. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:47Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T17:35:30Z urn:sha1:7086c19d07429d697057587caf1e5e0345442d16 Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:24Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T16:29:55Z urn:sha1:a2cc5ba075f9bc837d0b4d4ec7328dcefc11859d Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:23Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T16:27:05Z urn:sha1:fd2819bbc92fc98bed5d612e4acbe16b6326f6bf Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:20Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T15:35:41Z urn:sha1:eda95cbf75193808f62948fb0142ba0901d8bee2 Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:19Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T15:30:16Z urn:sha1:329ad399a9b3adf52c90637b21ca029fcf7f8795 Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:25:11Z Artem Bityutskiy artem.bityutskiy@linux.intel.com 2011-12-23T13:25:39Z urn:sha1:7e1f0dc0551b99acb5e8fa161a7ac401994d57d8 This patch is part of a patch-set which changes the MTD interface from 'mtd->func()' form to 'mtd_func()' form. We need this because we want to add common code to to all drivers in the mtd core level, which is impossible with the current interface when MTD clients call driver functions like 'read()' or 'write()' directly. At this point we just introduce a new inline wrapper function, but later some of them are expected to gain more code. E.g., the input parameters check should be moved to the wrappers rather than be duplicated at many drivers. This particular patch introduced the 'mtd_erase()' interface. The following patches add all the other interfaces one by one. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2012-01-09T18:12:42Z Wolfram Sang w.sang@pengutronix.de 2011-11-29T14:34:08Z urn:sha1:2f4478ccff7df845dc9c0f8996a96373122c4417 stresstest needs at least two eraseblocks. Bail out gracefully if that condition is not met. Fixes the following 'division by zero' OOPS: [ 619.100000] mtd_stresstest: MTD device size 131072, eraseblock size 131072, page size 2048, count of eraseblocks 1, pages per eraseblock 64, OOB size 64 [ 619.120000] mtd_stresstest: scanning for bad eraseblocks [ 619.120000] mtd_stresstest: scanned 1 eraseblocks, 0 are bad [ 619.130000] mtd_stresstest: doing operations [ 619.130000] mtd_stresstest: 0 operations done [ 619.140000] Division by zero in kernel. ... caused by /* Read or write up 2 eraseblocks at a time - hence 'ebcnt - 1' */ eb %= (ebcnt - 1); Cc: stable@kernel.org Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 2011-10-30T12:31:04Z Wolfram Sang w.sang@pengutronix.de 2011-10-29T22:11:53Z urn:sha1:7406060e292c389fe6f38bd23493de9b57f2f4fc mtd tests may erase the mtd device, so force the user to specify which mtd device to test by using the module parameter. Disable the default (using mtd0) since this may destroy a vital part of the flash if the module is inserted accidently or carelessly. Reported-by: Roland Kletzing <devzero@web.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@intel.com>