linux/drivers/input/touchscreen/tsc2005.c, branch v3.2.31

Input: tsc2005 - fix locking issue

2011-03-24T06:50:36Z

Commit 0b950d3 (Input: tsc2005 - add open/close) introduced a locking issue with the ESD watchdog: __tsc2005_disable() is calling cancel_delayed_work_sync() with mutex held, and the work also needs the same mutex. Fix the problem by using mutex_trylock() in tsc2005_esd_work(). If the mutex is taken, we know we are in the middle of disable or enable and the watchdog check can be skipped. Signed-off-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - use relative jiffies to schedule the watchdog

2011-03-24T06:50:31Z

Use relative jiffies to schedule the watchdog. Otherwise it will run like a mad one. Signed-off-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - driver should depend on GENERIC_HARDIRQS

2011-03-24T06:49:17Z

drivers/input/touchscreen/tsc2005.c: In function ‘tsc2005_probe’: drivers/input/touchscreen/tsc2005.c:666: error: implicit declaration of function ‘set_irq_wake’ In addition, migrate from set_irq_wake() (marked "do not use" as of commit a0cd9ca2b907d7ee26575e7b63ac92dad768a75e ("genirq: Namespace cleanup")) to irq_set_irq_wake(). Signed-off-by: Geert Uytterhoeven Signed-off-by: Dmitry Torokhov

Input: tsc2005 - remove 'disable' sysfs attribute

2011-03-17T06:29:33Z

I believe that enable/disable functionality should not be implemented on the individual driver level but rather in device core, potentially reusing parts of PM framework. Therefore the driver-specific "disable" attribute is removed from the mainline driver. Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - add open/close

2011-03-17T06:29:29Z

Introduce open and close methods for the input device to keep the device powered down when it is not in use. Also rework interaction between interrupt thread and starting/shutting off/resetting the device: instead of taking a mutex in the intterrupt thread and elsewhere disable interrupts before transitioning the device in a new state. The ESD handling is also separated from the IRQ thread; we poll regularly at a given interval and simply skip reads if we see that valid interrupt happened not so long ago. This allows us not cancel and reschedule ESD work from interrupt context all the time. Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - handle read errors from SPI layer

2011-03-17T06:29:22Z

Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - do not rearm timer in hardirq handler

2011-03-17T06:29:16Z

We will most likely rearm it yet again the IRQ thread so doing it here is pointless. Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - don't use work for 'pen up' handling

2011-03-17T06:29:12Z

We do not need process context to send input events so let's switch to a regular timer. I am going to get rid of taking ts->mutex in tsc2005_irq_thread() later. Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - do not use 0 in place of NULL

2011-03-17T06:29:08Z

Sparse in unhappy when people use 0 instead of NULL for pointers so let's rework the way we initialize spi_transfer structure in tsc2005_cmd() and tsc2005_write(). Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov

Input: tsc2005 - use true/false for boolean variables

2011-03-17T06:29:04Z

Tested-by: Aaro Koskinen Signed-off-by: Dmitry Torokhov