linux/drivers/input/ff-core.c, branch v2.6.27.59Linux kernel source treehttps://git.amat.us/linux/atom/drivers/input/ff-core.c?h=v2.6.27.592008-07-03T01:40:08Zdrivers/input/ff-core.c needs <linux/sched.h>2008-07-03T01:40:08ZGeert Uytterhoevengeert@linux-m68k.org2008-07-01T11:55:25Zurn:sha1:83680cdbcecd1fd284ad4df060d12bf214bb63a8
Commit 656acd2bbc4ce7f224de499ee255698701396c48 ("Input: fix locking in
force-feedback core") causes the following regression on m68k:
| linux/drivers/input/ff-core.c: In function 'input_ff_upload':
| linux/drivers/input/ff-core.c:172: error: dereferencing pointer to incomplete type
| linux/drivers/input/ff-core.c: In function 'erase_effect':
| linux/drivers/input/ff-core.c:197: error: dereferencing pointer to incomplete type
| linux/drivers/input/ff-core.c:204: error: dereferencing pointer to incomplete type
| make[4]: *** [drivers/input/ff-core.o] Error 1
As the incomplete type is `struct task_struct', including <linux/sched.h> fixes
it.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Input: fix locking in force-feedback core2008-06-30T13:26:02ZDmitry Torokhovdmitry.torokhov@gmail.com2008-06-26T15:30:02Zurn:sha1:656acd2bbc4ce7f224de499ee255698701396c48
The newly added event_lock spinlock in the input core disallows sleeping
and therefore using mutexes in event handlers. Convert force-feedback
core to rely on event_lock instead of mutex to protect slots allocated
for fore-feedback effects. The original mutex is still used to serialize
uploading and erasing of effects.
Reported-by: Anssi Hannula <anssi.hannula@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Input: force feedback - make sure effect is present before playing2007-05-03T04:51:10ZDmitry Torokhovdtor@insightbb.com2007-05-03T04:51:10Zurn:sha1:dec3eb01c2409ca8276c1152c167add66a37d1ba
Make sure that requested effect id is not out of range for the
device and that effect is present before requesting device to
play it.
Reported-by: Jan Kratochvil <honza@jikos.cz>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Input: add to kernel-api docbook2006-11-24T05:43:09ZRandy Dunlaprandy.dunlap@oracle.com2006-11-24T05:43:09Zurn:sha1:e4477d2d1bc3e6c76e83926f7fa8c8f94ba42615
Add input subsystem to kernel-api docbook.
Enhance some function and parameter comments.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Input: implement new force feedback interface2006-07-19T05:40:22ZAnssi Hannulaanssi.hannula@gmail.com2006-07-19T05:40:22Zurn:sha1:509ca1a9383601fdc5612d3d3ba5b981f6eb6c8b
Implement a new force feedback interface, in which all non-driver-specific
operations are separated to a common module. This includes handling effect
type validations, locking, etc.
The effects are now file descriptor specific instead of the previous strange
half-process half-fd specific behaviour. The effect memory of devices is not
emptied if the root user opens and closes the device while another user is
using effects. This is a minor change and most likely no force feedback
aware programs are affected by this negatively.
Otherwise the userspace interface is left unaltered.
Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>