linux/drivers/block/drbd, branch v3.9

drbd: convert to idr_alloc()

2013-02-28T03:10:15Z

Convert to the much saner new idr interface. Signed-off-by: Tejun Heo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drbd: fix potential protocol error and resulting disconnect/reconnect

2013-01-21T21:58:36Z

When we notice a disk failure on the receiving side, we stop sending it new incoming writes. Depending on exact timing of various events, the same transfer log epoch could end up containing both replicated (before we noticed the failure) and local-only requests (after we noticed the failure). The sanity checks in tl_release(), called when receiving a P_BARRIER_ACK, check that the ack'ed transfer log epoch matches the expected epoch, and the number of contained writes matches the number of ack'ed writes. In this case, they counted both replicated and local-only writes, but the peer only acknowledges those it has seen. We get a mismatch, resulting in a protocol error and disconnect/reconnect cycle. Messages logged are "BAD! BarrierAck #%u received with n_writes=%u, expected n_writes=%u!\n" A similar issue can also be triggered when starting a resync while having a healthy replication link, by invalidating one side, forcing a full sync, or attaching to a diskless node. Fix this by closing the current epoch if the state changes in a way that would cause the replication intent of the next write. Epochs now contain either only non-replicated, or only replicated writes. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: update Kconfig to match current dependencies

2012-12-06T12:08:29Z

We no longer need the connector. But we need libcrc32c. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: Fix drbdsetup wait-connect, wait-sync etc... commands

2012-12-06T12:04:34Z

This was introduces when moving the code over from the 8.3 codebase with commit 328e0f125bf41f4f33f684db22015f92cb44fe56 Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: close race between drbd_set_role and drbd_connect

2012-12-06T12:00:33Z

drbd_set_role(, R_PRIMARY, ) does the state change to Primary, some more housekeeping, and possibly generates a new UUID set. All of this holding the "state_mutex". The connection handshake involves sending of various state information, including the current data generation UUID set, and two connection state changes from C_WF_CONNECTION to C_WF_REPORT_PARAMS further to a number of different outcomes, resync being one of them. If the connection handshake happens between the state change to Primary and the generation of the new UUIDs, the resync decision based on the old UUID set may be confused, depending on circumstances. Make sure that, before we do the handshake, any promotion to Primary role will either be complete (including the housekeeping stuff), or can see, and serialize with, the ongoing handshake, based on the "STATE_SENT" bit, which is set when we start the handshake, and cleared only when we leave C_WF_REPORT_PARAMS again. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: respect no-md-barriers setting also when changed online via disk-options

2012-12-06T12:00:04Z

We need to propagate the configuration into the flag bits, or it won't be effective. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: Remove obsolete check

2012-12-06T11:09:55Z

Smatch complained about it this redundanct check. The check was introduced in 2006-09-13. On 2007-07-24 the body of the function was enclosed by get_ldev()/put_ldev() reference counting. Since then the check is useless and miss leading. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: fixup after wait_even_lock_irq() addition to generic code

2012-11-30T20:20:15Z

Compiling drbd yields: drivers/block/drbd/drbd_state.c: In function ‘_conn_request_state’: drivers/block/drbd/drbd_state.c:1804:5: error: macro "wait_event_lock_irq" passed 4 arguments, but takes just 3 drivers/block/drbd/drbd_state.c:1801:3: error: ‘wait_event_lock_irq’ undeclared (first use in this function) drivers/block/drbd/drbd_state.c:1801:3: note: each undeclared identifier is reported only once for each function it appears in drivers/block/drbd/drbd_state.c: At top level: drivers/block/drbd/drbd_state.c:1734:1: warning: ‘_conn_rq_cond’ defined but not used [-Wunused-function] Due to drbd having copied the MD definition for wait_event_lock_irq() as well. Kill them. Signed-off-by: Jens Axboe

drbd: use copy_highpage

2012-11-09T13:22:26Z

Use copy_highpage() to copy from one page to another. Signed-off-by: Akinobu Mita Signed-off-by: Andrew Morton Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

drbd: if the replication link breaks during handshake, keep retrying

2012-11-09T13:22:19Z

The 8.3.12 commit drbd: Bugfix for the connection behavior fixes a "wasted established connection", if a former connection attempt failed during its early stages. However it opened a window for a regression, if a connection attempt fails during its last stages. The result was a terminated receiver thread, that left behind the supposedly transient "C_UNCONNECTED" state. Any later requests to change the connection state fail, as they wait for the connection state to "stabilize". Fix: short circuit and keep retrying to restablish a new connection, if we don't reach C_WF_REPORT_PARAMS. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg