linux/drivers/base/regmap/regmap.c, branch v3.10.27

regmap: cache: bail in regmap_async_complete() for bus-less maps

2013-08-04T08:50:58Z

commit f2e055e7c9c6084bfbaa68701e52562acf96419e upstream. Commit f8bd822cb ("regmap: cache: Factor out block sync") made regcache_rbtree_sync() call regmap_async_complete(), which in turn does not check for map->bus before dereferencing it. This causes a NULL pointer dereference on bus-less maps. Signed-off-by: Daniel Mack Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

Merge remote-tracking branch 'regmap/topic/cache' into regmap-next

2013-04-16T15:05:46Z

Merge remote-tracking branch 'regmap/topic/async' into regmap-next

2013-04-16T15:05:44Z

regmap: don't corrupt work buffer in _regmap_raw_write()

2013-04-16T15:05:03Z

_regmap_raw_write() contains code to call regcache_write() to write values to the cache. That code calls memcpy() to copy the value data to the start of the work_buf. However, at least when _regmap_raw_write() is called from _regmap_bus_raw_write(), the value data is in the work_buf, and this memcpy() operation may over-write part of that value data, depending on the value of reg_bytes + pad_bytes. At least when using reg_bytes==1 and pad_bytes==0, corruption of the value data does occur. To solve this, remove the memcpy() operation, and modify the subsequent .parse_val() call to parse the original value buffer directly. At least in the case of 8-bit register address and 16-bit values, and writes of single registers at a time, this memcpy-then-parse combination used to cancel each-other out; for a work-buffer containing xx 89 03, the memcpy changed it to 89 03 03, and the parse_val changed it back to 89 89 03, thus leaving the value uncorrupted. This appears completely accidental though. Since commit 8a819ff "regmap: core: Split out in place value parsing", .parse_val only returns the parsed value, and does not modify the buffer, and hence does not (accidentally) undo the corruption caused by memcpy(). This caused bogus values to get written to HW, thus preventing e.g. audio playback on systems with a WM8903 CODEC. This patch fixes that. Signed-off-by: Stephen Warren Signed-off-by: Mark Brown

Merge tag 'v3.9-rc7' into regmap-cache

2013-04-16T15:02:41Z

Linux 3.9-rc7

regmap: Back out work buffer fix

2013-04-09T17:03:25Z

This reverts commit bc8ce4 (regmap: don't corrupt work buffer in _regmap_raw_write()) since it turns out that it can cause issues when taken in isolation from the other changes in -next that lead to its discovery. On the basis that nobody noticed the problems for quite some time without that subsequent work let's drop it from v3.9. Signed-off-by: Mark Brown

Merge remote-tracking branch 'regmap/fix/async' into tmp

2013-03-31T22:27:38Z

Merge remote-tracking branch 'regmap/fix/core' into tmp

2013-03-31T22:09:22Z

regmap: async: Add missing return

2013-03-27T13:08:44Z

Let's only write once... Signed-off-by: Mark Brown

regmap: core: Provide regmap_can_raw_write() operation

2013-03-27T13:03:39Z

Mainly useful internally but exported since this is a public API that's being checked for. Signed-off-by: Mark Brown