linux/drivers/atm, branch v3.16

atm: fore200e.c: Cleaning up uninitialized variables

2014-06-03T00:11:03Z

There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist Signed-off-by: David S. Miller

atm: idt77252: Remove redundant error check

2014-05-21T19:56:26Z

Remove double checks, convert printk to pr_warn, and move the call to pr_warn to the first check. The simplified version of the coccinelle semantic patch that find this issue is as follows: // @@ expression E; identifier pr; expression list es; @@ while(...){ ... - if (E) break; + if (E){ + pr(es); + break; + } ... } - if(E) pr(es); // Tested by compilation only. Signed-off-by: Peter Senna Tschudin Signed-off-by: David S. Miller

atm: idt77105: Use del_timer_sync() in exit path

2014-03-26T01:06:02Z

The module is about to go away. Make sure everything is stopped safely before we pull the plug. Signed-off-by: Thomas Gleixner Cc: Chas Williams Cc: atm Cc: netdev Signed-off-by: David S. Miller

atm: firestream: Use del_timer_sync() in teardown path

2014-03-26T01:06:02Z

The device is about to vanish. So we need to make sure that the timer is completely stopped and the callback is not running on another CPU. Signed-off-by: Thomas Gleixner Cc: Chas Williams Cc: atm Cc: netdev Signed-off-by: David S. Miller

atm: nicstar: remove interruptible_sleep_on_timeout

2014-02-27T20:22:46Z

We are trying to finally kill off interruptible_sleep_on_timeout. the two uses in the nicstar driver can be trivially replaced with wait_event_interruptible_lock_irq_timeout, which prevents the wake-up race and is able to check the buffer state with scq->lock held. Signed-off-by: Arnd Bergmann Acked-by: Chas Williams Signed-off-by: David S. Miller

atm: firestream: fix interruptible_sleep_on race

2014-02-26T21:06:12Z

interruptible_sleep_on is racy and going away. This replaces the one use in the firestream driver with the appropriate wait_event_interruptible variant. Signed-off-by: Arnd Bergmann Acked-by: Chas Williams Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller

atm: solos-pci: make solos_bh() as static

2014-02-19T21:39:11Z

sparse says: drivers/atm/solos-pci.c:763:6: warning: symbol 'solos_bh' was not declared. Should it be static? Signed-off-by: Daeseok Youn Acked-by: Chas Williams Signed-off-by: David S. Miller

atm: nicstar: use NULL instead of 0 for pointer

2014-02-19T21:39:11Z

sparse says: drivers/atm/nicstar.c:642:27: warning: Using plain integer as NULL pointer drivers/atm/nicstar.c:644:27: warning: Using plain integer as NULL pointer drivers/atm/nicstar.c:982:51: warning: Using plain integer as NULL pointer drivers/atm/nicstar.c:996:51: warning: Using plain integer as NULL pointer Signed-off-by: Daeseok Youn Acked-by: Chas Williams Signed-off-by: David S. Miller

atm: ambassador: use NULL instead of 0 for pointer

2014-02-19T21:39:10Z

sparse says: drivers/atm/ambassador.c:1928:24: warning: Using plain integer as NULL pointer Signed-off-by: Daeseok Youn Acked-by: Chas Williams Signed-off-by: David S. Miller

atm: slight optimization of addr compare

2013-12-26T18:31:34Z

Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Chas Williams Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Yang Yingliang Signed-off-by: Ding Tianhong Signed-off-by: David S. Miller