<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux/drivers/ata, branch v2.6.21.2</title>
<subtitle>Linux kernel source tree</subtitle>
<id>https://git.amat.us/linux/atom/drivers/ata?h=v2.6.21.2</id>
<link rel='self' href='https://git.amat.us/linux/atom/drivers/ata?h=v2.6.21.2'/>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/'/>
<updated>2007-05-23T21:32:42Z</updated>
<entry>
<title>[PATCH] sata_via: add missing PM hooks</title>
<updated>2007-05-23T21:32:42Z</updated>
<author>
<name>Tejun Heo</name>
<email>htejun@gmail.com</email>
</author>
<published>2007-05-04T13:30:34Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=dc47041995b0db572085a5ddf87e099f9977ea38'/>
<id>urn:sha1:dc47041995b0db572085a5ddf87e099f9977ea38</id>
<content type='text'>
For some reason, sata_via is missing PM hooks.  Add them.  Spotted by
Jeroen Janssen &lt;jeroen.janssen@gmail.com&gt;.

Signed-off-by: Tejun Heo &lt;htejun@gmail.com&gt;
Cc: Jeroen Janssen &lt;jeroen.janssen@gmail.com&gt;
Signed-off-by: Chris Wright &lt;chrisw@sous-sol.org&gt;
</content>
</entry>
<entry>
<title>[PATCH] libata-sff: Undo bug introduced with pci_iomap changes</title>
<updated>2007-05-23T21:32:42Z</updated>
<author>
<name>Alan Cox</name>
<email>alan@lxorguk.ukuu.org.uk</email>
</author>
<published>2007-05-01T11:53:27Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=c91d41705988070fe841569a53b5d9789ed60c7c'/>
<id>urn:sha1:c91d41705988070fe841569a53b5d9789ed60c7c</id>
<content type='text'>
If you have a controller with one channel disabled and unmapped the new
iomap code blindly tries to iomap unconfigured BARs. Later on the code
does the right thing and checks for unmapped bars but it is done in the
wrong order

Reorder the checks and make the iomap conditional

Tejun: I think the code below is now correct but would appreciate you
giving it a review.

Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Acked-by: Tejun Heo &lt;htejun@gmail.com&gt;
Signed-off-by: Chris Wright &lt;chrisw@sous-sol.org&gt;
</content>
</entry>
<entry>
<title>pata_sis: Fix oops on boot</title>
<updated>2007-04-19T23:20:52Z</updated>
<author>
<name>Alan Cox</name>
<email>alan@lxorguk.ukuu.org.uk</email>
</author>
<published>2007-04-19T10:09:52Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=f3769e9db11df38c211881a5f11b2e38a8e4477a'/>
<id>urn:sha1:f3769e9db11df38c211881a5f11b2e38a8e4477a</id>
<content type='text'>
A small number of SiS setups require special handling (not many judging
by how long this dumb bug survived). A couple of Fedora 7 devel testers
hit an Oops on pata_sis loading which is caused by terminal confusion
between chipset as 'the chipset we have found' and chipset as 'array
iterator'

Signed-off-by: Alan Cox &lt;alan@redhat.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
<entry>
<title>Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev</title>
<updated>2007-04-04T15:44:40Z</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@woody.linux-foundation.org</email>
</author>
<published>2007-04-04T15:44:40Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=bb4899dbef2650288d20251a736243472f050d8b'/>
<id>urn:sha1:bb4899dbef2650288d20251a736243472f050d8b</id>
<content type='text'>
* 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
  libata: Limit ATAPI DMA to R/W commands only for TORiSAN DVD drives (take 3)
  libata: Limit max sector to 128 for TORiSAN DVD drives (take 3)
  libata: Clear tf before doing request sense (take 3)
  libata: reorder HSM_ST_FIRST for easier decoding (take 3)
  libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
  2.6.21 fix lba48 bug in libata fill_result_tf()
</content>
</entry>
<entry>
<title>[PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver (v2)</title>
<updated>2007-04-04T15:40:17Z</updated>
<author>
<name>Robert Hancock</name>
<email>hancockr@shaw.ca</email>
</author>
<published>2007-04-03T04:05:29Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=36e337d0244ddcf4317f7d7c1144b9adfc8e5e3a'/>
<id>urn:sha1:36e337d0244ddcf4317f7d7c1144b9adfc8e5e3a</id>
<content type='text'>
This adds some NCQ blacklist entries taken from the Silicon Image 3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example http://lkml.org/lkml/2007/3/4/178)
so let's disable NCQ on these drives.

 [ I'm personally starting to wonder whether we shouldn't disable NCQ by
   default, and perhaps have a white-list. There seems to be a *lot* of
   drives that do this wrong..   - Linus ]

Signed-off-by: Robert Hancock &lt;hancockr@shaw.ca&gt;
Acked-by: Tejun Heo &lt;htejun@gmail.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
<entry>
<title>libata: Limit ATAPI DMA to R/W commands only for TORiSAN DVD drives (take 3)</title>
<updated>2007-04-04T06:12:27Z</updated>
<author>
<name>Albert Lee</name>
<email>albertcc@tw.ibm.com</email>
</author>
<published>2007-04-02T03:39:25Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=6f23a31d1cbe791a1ce86ffa9b23251ab0a1ef45'/>
<id>urn:sha1:6f23a31d1cbe791a1ce86ffa9b23251ab0a1ef45</id>
<content type='text'>
patch 4/4:

  Limit ATAPI DMA to R/W commands only for TORiSAN DRD-N216 DVD-ROM drives
  (http://bugzilla.kernel.org/show_bug.cgi?id=6710)

Signed-off-by: Albert Lee &lt;albertcc@tw.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
<entry>
<title>libata: Limit max sector to 128 for TORiSAN DVD drives (take 3)</title>
<updated>2007-04-04T06:12:27Z</updated>
<author>
<name>Albert Lee</name>
<email>albertcc@tw.ibm.com</email>
</author>
<published>2007-04-02T03:34:15Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=18d6e9d51891f91af4e7351cbab3cb180bb9f430'/>
<id>urn:sha1:18d6e9d51891f91af4e7351cbab3cb180bb9f430</id>
<content type='text'>
patch 3/4:
  The TORiSAN drive locks up when max sector == 256.
  Limit max sector to 128 for the TORiSAN DRD-N216 drives.
  (http://bugzilla.kernel.org/show_bug.cgi?id=6710)

Signed-off-by: Albert Lee &lt;albertcc@tw.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
<entry>
<title>libata: Clear tf before doing request sense (take 3)</title>
<updated>2007-04-04T06:12:27Z</updated>
<author>
<name>Albert Lee</name>
<email>albertcc@tw.ibm.com</email>
</author>
<published>2007-04-02T03:30:46Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=56287768e31268969abd94b38b931a29d1ced1ce'/>
<id>urn:sha1:56287768e31268969abd94b38b931a29d1ced1ce</id>
<content type='text'>
patch 2/4:
  Clear tf before doing request sense.

This fixes the AOpen 56X/AKH timeout problem.
(http://bugzilla.kernel.org/show_bug.cgi?id=8244)

Signed-off-by: Albert Lee &lt;albertcc@tw.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
<entry>
<title>libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK</title>
<updated>2007-04-04T06:07:28Z</updated>
<author>
<name>Mark Lord</name>
<email>mlord@pobox.com</email>
</author>
<published>2007-03-30T21:45:52Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=277239f228654fc03affdf2aa0e7a3969f420415'/>
<id>urn:sha1:277239f228654fc03affdf2aa0e7a3969f420415</id>
<content type='text'>
Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.

Signed-off-by:  Mark Lord &lt;mlord@pobox.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
<entry>
<title>2.6.21 fix lba48 bug in libata fill_result_tf()</title>
<updated>2007-04-04T06:07:28Z</updated>
<author>
<name>Mark Lord</name>
<email>liml@rtr.ca</email>
</author>
<published>2007-04-02T20:20:35Z</published>
<link rel='alternate' type='text/html' href='https://git.amat.us/linux/commit/?id=4742d54fa4b391342dfb8f34de14d51da101fb39'/>
<id>urn:sha1:4742d54fa4b391342dfb8f34de14d51da101fb39</id>
<content type='text'>
Current 2.6.21 libata does the following:

void ata_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
{
        struct ata_ioports *ioaddr = &amp;ap-&gt;ioaddr;

        tf-&gt;command = ata_check_status(ap);
	...
        if (tf-&gt;flags &amp; ATA_TFLAG_LBA48) {
                iowrite8(tf-&gt;ctl | ATA_HOB, ioaddr-&gt;ctl_addr);
                tf-&gt;hob_feature = ioread8(ioaddr-&gt;error_addr);
                ...
        }
}
...
static void fill_result_tf(struct ata_queued_cmd *qc)
{
        struct ata_port *ap = qc-&gt;ap;

        ap-&gt;ops-&gt;tf_read(ap, &amp;qc-&gt;result_tf);
        qc-&gt;result_tf.flags = qc-&gt;tf.flags;
}

Based on this, those last two statements fill_result_tf()
appear to me to be in the wrong order, in that the tf-&gt;flags
are uninitialized at the point where tf_read() is invoked.
So for lba48 commands, tf_read() won't be reading back the
full lba48 register contents..

Correct?

This patch corrects fill_result_tf() so that the flags
get copied to result_tf before they are used by tf_read().

Signed-off-by:  Mark Lord &lt;mlord@pobox.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
</entry>
</feed>
