linux/block/partitions, branch v3.16

block: Use macros from compiler.h instead of attribute((...))

2014-02-18T20:20:01Z

To increase compiler portability there are several macros defined in for various gcc __attribute((..)) constructs. I've made sure gcc these specific were replaced with the right macro and an #include was placed where needed. Signed-off-by: Gideon Israel Dsouza Signed-off-by: Jens Axboe

block/partitions/efi.c: fix bound check

2013-11-22T00:42:27Z

Use ARRAY_SIZE instead of sizeof to get proper max for label length. Since this is just a read out of bounds it's not that bad, but the problem becomes user-visible eg if one tries to use DEBUG_PAGEALLOC and DEBUG_RODATA, at least with some enhancements from Hiroshi. Of course the destination array can contain garbage when we read beyond the end of source array so that would be another user-visible problem. Signed-off-by: Antti P Miettinen Reviewed-by: Hiroshi Doyu Tested-by: Hiroshi Doyu Cc: Will Drewry Cc: Matt Fleming Acked-by: Davidlohr Bueso Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

block/partitions/efi.c: treat size mismatch as a warning, not an error

2013-10-17T04:35:53Z

In commit 27a7c642174e ("partitions/efi: account for pmbr size in lba") we started treating bad sizes in lba field of the partition that has the 0xEE (GPT protective) as errors. However, we may run into these "bad sizes" in the real world if someone uses dd to copy an image from a smaller disk to a bigger disk. Since this case used to work (even without using force_gpt), keep it working and treat the size mismatch as a warning instead of an error. Reported-by: Josh Triplett Reported-by: Sean Paul Signed-off-by: Doug Anderson Reviewed-by: Josh Triplett Acked-by: Davidlohr Bueso Tested-by: Artem Bityutskiy Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

block: change config option name for cmdline partition parsing

2013-09-30T21:31:02Z

Recently commit bab55417b10c ("block: support embedded device command line partition") introduced CONFIG_CMDLINE_PARSER. However, that name is too generic and sounds like it enables/disables generic kernel boot arg processing, when it really is block specific. Before this option becomes a part of a full/final release, add the BLK_ prefix to it so that it is clear in absence of any other context that it is block specific. In addition, fix up the following less critical items: - help text was not really at all helpful. - index file for Documentation was not updated - add the new arg to Documentation/kernel-parameters.txt - clarify wording in source comments Signed-off-by: Paul Gortmaker Cc: Jens Axboe Cc: Cai Zhiyong Cc: Wei Yongjun Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

partitions/efi: loosen check fot pmbr size in lba

2013-09-15T11:10:16Z

Matt found that commit 27a7c642174e ("partitions/efi: account for pmbr size in lba") caused his GPT formatted eMMC device not to boot. The reason is that this commit enforced Linux to always check the lesser of the whole disk or 2Tib for the pMBR size in LBA. While most disk partitioning tools out there create a pMBR with these characteristics, Microsoft does not, as it always sets the entry to the maximum 32-bit limitation - even though a drive may be smaller than that[1]. Loosen this check and only verify that the size is either the whole disk or 0xFFFFFFFF. No tool in its right mind would set it to any value other than these. [1] http://thestarman.pcministry.com/asm/mbr/GPT.htm#GPTPT Reported-and-tested-by: Matt Porter Signed-off-by: Davidlohr Bueso Signed-off-by: Linus Torvalds

block/partitions/efi.c: consistently use pr_foo()

2013-09-11T22:59:19Z

Cc: Davidlohr Bueso Cc: Karel Zak Cc: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

partitions/efi: some style cleanups

2013-09-11T22:59:19Z

Trivial coding style cleanups - still plenty left. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Davidlohr Bueso Reviewed-by: Karel Zak Acked-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

partitions/efi: delete annoying emacs style comments

2013-09-11T22:59:18Z

I love emacs, but these settings for coding style are annoying when trying to open the efi.h file. More important, we already have checkpatch for that. Signed-off-by: Davidlohr Bueso Reviewed-by: Karel Zak Acked-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

partitions/efi: compare first and last usable LBAs

2013-09-11T22:59:18Z

When verifying GPT header integrity, make sure that first usable LBA is smaller than last usable LBA. Signed-off-by: Davidlohr Bueso Reviewed-by: Karel Zak Acked-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

partitions/efi: account for pmbr size in lba

2013-09-11T22:59:17Z

The partition that has the 0xEE (GPT protective), must have the size in lba field set to the lesser of the size of the disk minus one or 0xFFFFFFFF for larger disks. Signed-off-by: Davidlohr Bueso Reviewed-by: Karel Zak Acked-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

linux/block/partitions, branch v3.16

block: Use macros from compiler.h instead of __attribute__((...))

block/partitions/efi.c: fix bound check

block/partitions/efi.c: treat size mismatch as a warning, not an error

block: change config option name for cmdline partition parsing

partitions/efi: loosen check fot pmbr size in lba

block/partitions/efi.c: consistently use pr_foo()

partitions/efi: some style cleanups

partitions/efi: delete annoying emacs style comments

partitions/efi: compare first and last usable LBAs

partitions/efi: account for pmbr size in lba

block: Use macros from compiler.h instead of attribute((...))