Linux kernel source tree https://git.amat.us/linux/atom/arch/um/os-Linux/execvp.c?h=v3.5 2006-11-25T21:28:34Z 2006-11-25T21:28:34Z Paolo 'Blaisorblade' Giarrusso blaisorblade@yahoo.it 2006-11-25T19:09:39Z urn:sha1:5d48545e5e88ab7a27ba6a5cb1e8fff617754b61 Reimplement execvp for our purposes - after we call fork() it is fundamentally unsafe to use the kernel allocator - current is not valid there. So we simply pass to our modified execvp() a preallocated buffer. This fixes a real bug and works very well in testing (I've seen indirectly warning messages from the forked thread - they went on the pipe connected to its stdout and where read as a number by UML, when calling read_output(). I verified the obtained number corresponded to "BUG:"). The added use of __cant_sleep() is not a new bug since __cant_sleep() is already used in the same function - passing an atomicity parameter would be better but it would require huge change, stating that this function must not be called in atomic context and can sleep is a better idea (will make sure of this gradually). Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Acked-by: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>