aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAlon Zakai <alonzakai@gmail.com>2013-08-14 16:42:49 -0700
committerAlon Zakai <alonzakai@gmail.com>2013-08-14 16:42:49 -0700
commit927a4b3399574f1f0254e611efdd216f1784478a (patch)
treea24f463e600c2c76e941219971a89b6997ce12f2 /src
parentb1178a4c94ade03099f483ec2878cffb7a49b1ee (diff)
parent83b0ec50152d58b185e91d10713231dbb790ceae (diff)
Merge pull request #1514 from inolen/default_open_mode
default to mode 0666 in FS.open
Diffstat (limited to 'src')
-rw-r--r--src/library.js2
-rw-r--r--src/library_fs.js1
2 files changed, 1 insertions, 2 deletions
diff --git a/src/library.js b/src/library.js
index 33b1f1aa..ee49ae1f 100644
--- a/src/library.js
+++ b/src/library.js
@@ -478,8 +478,6 @@ LibraryManager.library = {
open: function(path, oflag, varargs) {
// int open(const char *path, int oflag, ...);
// http://pubs.opengroup.org/onlinepubs/009695399/functions/open.html
- // NOTE: This implementation tries to mimic glibc rather than strictly
- // following the POSIX standard.
var mode = {{{ makeGetValue('varargs', 0, 'i32') }}};
path = Pointer_stringify(path);
try {
diff --git a/src/library_fs.js b/src/library_fs.js
index c9aa9900..d6cfe7f5 100644
--- a/src/library_fs.js
+++ b/src/library_fs.js
@@ -1213,6 +1213,7 @@ mergeInto(LibraryManager.library, {
open: function(path, flags, mode, fd_start, fd_end) {
path = PATH.normalize(path);
flags = typeof flags === 'string' ? FS.modeStringToFlags(flags) : flags;
+ mode = typeof mode === 'undefined' ? 0666 : mode;
if ((flags & {{{ cDefine('O_CREAT') }}})) {
mode = (mode & {{{ cDefine('S_IALLUGO') }}}) | {{{ cDefine('S_IFREG') }}};
} else {